lbrycrd/contrib/devtools
MarcoFalke 3cf76c23fb
Merge #12933: doc: Refine header include policy
fad0fc3c9a Refine travis check for duplicate includes (MarcoFalke)

Pull request description:

  Since there is no harm in having "duplicate" includes and it makes it obvious what are the dependencies of each file, without having to do static analysis or jumping between files, I'd suggest to revert the travis check for duplicate includes.

  Generally, I think that enforcing minor style preferences should not be done via travis. The cost of maintaining and the burden on other developers is too high. C.f discussion in https://github.com/bitcoin/bitcoin/pull/10973#discussion_r180142594

Tree-SHA512: 97ab0e769d457ccfb873fff6c99613f8b944cd7ef95bfdccb0e1bbe8f5df1f16548c658fa03af42516f806546e75646d338a061e7b057619490235d311ca21f1
2018-04-11 10:45:47 -04:00
..
check-doc.py contrib: Fix check-doc script regexes 2018-03-28 14:13:29 -04:00
check-rpc-mappings.py qa: check-rpc-mapping must not run on empty lists 2017-10-01 16:46:56 +02:00
clang-format-diff.py contrib: Remove unused import string 2018-03-28 14:35:28 -04:00
commit-script-check.sh Fail on commit with VERIFY SCRIPT but no scripted-diff 2017-05-30 15:00:08 -07:00
copyright_header.py Merge #12075: [scripts] Add missing univalue file to copyright_header.py 2018-01-03 06:03:03 -09:00
gen-manpages.sh contrib: Add support for out-of-tree builds in gen-manpages.sh 2018-01-31 11:27:36 +01:00
git-subtree-check.sh Merge #11394: Perform a weaker subtree check in Travis 2017-11-09 17:06:20 -05:00
github-merge.py Remove assigned but never used local variables 2018-03-29 17:47:12 +02:00
lint-all.sh Add a lint check for trailing whitespace. 2017-09-14 10:49:48 +12:00
lint-include-guards.sh Add lint-include-guards.sh which checks include guard consistency 2018-03-22 19:41:16 +01:00
lint-includes.sh Refine travis check for duplicate includes 2018-04-10 15:12:42 -04:00
lint-logs.sh [logging] add lint-logs.sh to check for newline termination. 2018-04-07 12:29:52 -04:00
lint-python.sh Enable flake8 warning F841 ("local variable 'foo' is assigned to but never used") 2018-03-29 18:21:03 +02:00
lint-shell.sh Add shell script linting: Check for shellcheck warnings in shell scripts 2018-04-11 15:41:18 +02:00
lint-tests.sh tests: Add check for test suite name uniqueness in lint-tests.sh 2018-04-06 16:29:14 +02:00
lint-whitespace.sh Merge #12572: [script] lint-whitespace: find errors more easily 2018-03-11 17:30:04 -04:00
optimize-pngs.py Change all python files to use Python3 2018-03-26 16:49:33 -04:00
README.md [doc] devtools: Setup ots git integration 2018-04-09 08:23:24 -04:00
security-check.py [contrib] fixup security-check.py Python3 support 2018-03-28 15:46:54 -04:00
split-debug.sh.in build: add armhf/aarch64 gitian builds 2016-06-10 05:34:50 -04:00
symbol-check.py [contrib] fixup symbol-check.py Python3 support 2018-03-28 16:58:42 -04:00
test-security-check.py Increment MIT Licence copyright header year on files modified in 2017 2018-01-03 02:26:56 +09:00
update-translations.py Change all python files to use Python3 2018-03-26 16:49:33 -04:00

Contents

This directory contains tools for developers working on this repository.

check-doc.py

Check if all command line args are documented. The return value indicates the number of undocumented args.

clang-format-diff.py

A script to format unified git diffs according to .clang-format.

For instance, to format the last commit with 0 lines of context, the script should be called from the git root folder as follows.

git diff -U0 HEAD~1.. | ./contrib/devtools/clang-format-diff.py -p1 -i -v

copyright_header.py

Provides utilities for managing copyright headers of The Bitcoin Core developers in repository source files. It has three subcommands:

$ ./copyright_header.py report <base_directory> [verbose]
$ ./copyright_header.py update <base_directory>
$ ./copyright_header.py insert <file>

Running these subcommands without arguments displays a usage string.

Produces a report of all copyright header notices found inside the source files of a repository. Useful to quickly visualize the state of the headers. Specifying verbose will list the full filenames of files of each category.

Updates all the copyright headers of The Bitcoin Core developers which were changed in a year more recent than is listed. For example:

// Copyright (c) <firstYear>-<lastYear> The Bitcoin Core developers

will be updated to:

// Copyright (c) <firstYear>-<lastModifiedYear> The Bitcoin Core developers

where <lastModifiedYear> is obtained from the git log history.

This subcommand also handles copyright headers that have only a single year. In those cases:

// Copyright (c) <year> The Bitcoin Core developers

will be updated to:

// Copyright (c) <year>-<lastModifiedYear> The Bitcoin Core developers

where the update is appropriate.

Inserts a copyright header for The Bitcoin Core developers at the top of the file in either Python or C++ style as determined by the file extension. If the file is a Python file and it has #! starting the first line, the header is inserted in the line below it.

The copyright dates will be set to be <year_introduced>-<current_year> where <year_introduced> is according to the git log history. If <year_introduced> is equal to <current_year>, it will be set as a single year rather than two hyphenated years.

If the file already has a copyright for The Bitcoin Core developers, the script will exit.

gen-manpages.sh

A small script to automatically create manpages in ../../doc/man by running the release binaries with the -help option. This requires help2man which can be found at: https://www.gnu.org/software/help2man/

With in-tree builds this tool can be run from any directory within the repostitory. To use this tool with out-of-tree builds set BUILDDIR. For example:

BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

github-merge.py

A small script to automate merging pull-requests securely and sign them with GPG.

For example:

./github-merge.py 3077

(in any git repository) will help you merge pull request #3077 for the bitcoin/bitcoin repository.

What it does:

  • Fetch master and the pull request.
  • Locally construct a merge commit.
  • Show the diff that merge results in.
  • Ask you to verify the resulting source tree (so you can do a make check or whatever).
  • Ask you whether to GPG sign the merge commit.
  • Ask you whether to push the result upstream.

This means that there are no potential race conditions (where a pullreq gets updated while you're reviewing it, but before you click merge), and when using GPG signatures, that even a compromised GitHub couldn't mess with the sources.

Setup

Configuring the github-merge tool for the bitcoin repository is done in the following way:

git config githubmerge.repository bitcoin/bitcoin
git config githubmerge.testcmd "make -j4 check" (adapt to whatever you want to use for testing)
git config --global user.signingkey mykeyid (if you want to GPG sign)

Create and verify timestamps of merge commits

To create or verify timestamps on the merge commits, install the OpenTimestamps client via pip3 install opentimestamps-client. Then, dowload the gpg wrapper ots-git-gpg-wrapper.sh and set it as git's gpg.program. See the ots git integration documentation for further details.

optimize-pngs.py

A script to optimize png files in the bitcoin repository (requires pngcrush).

security-check.py and test-security-check.py

Perform basic ELF security checks on a series of executables.

symbol-check.py

A script to check that the (Linux) executables produced by gitian only contain allowed gcc, glibc and libstdc++ version symbols. This makes sure they are still compatible with the minimum supported Linux distribution versions.

Example usage after a gitian build:

find ../gitian-builder/build -type f -executable | xargs python contrib/devtools/symbol-check.py 

If only supported symbols are used the return value will be 0 and the output will be empty.

If there are 'unsupported' symbols, the return value will be 1 a list like this will be printed:

.../64/test_bitcoin: symbol memcpy from unsupported version GLIBC_2.14
.../64/test_bitcoin: symbol __fdelt_chk from unsupported version GLIBC_2.15
.../64/test_bitcoin: symbol std::out_of_range::~out_of_range() from unsupported version GLIBCXX_3.4.15
.../64/test_bitcoin: symbol _ZNSt8__detail15_List_nod from unsupported version GLIBCXX_3.4.15

update-translations.py

Run this script from the root of the repository to update all translations from transifex. It will do the following automatically:

  • fetch all translations
  • post-process them into valid and committable format
  • add missing translations to the build system (TODO)

See doc/translation-process.md for more information.