bffb35f876
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
53 lines
2.2 KiB
Python
Executable file
53 lines
2.2 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test spending coinbase transactions.
|
|
|
|
The coinbase transaction in block N can appear in block
|
|
N+100... so is valid in the mempool when the best block
|
|
height is N+99.
|
|
This test makes sure coinbase spends that will be mature
|
|
in the next block are accepted into the memory pool,
|
|
but less mature coinbase spends are NOT.
|
|
"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.blocktools import create_raw_transaction
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
|
|
|
|
|
class MempoolSpendCoinbaseTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def run_test(self):
|
|
chain_height = self.nodes[0].getblockcount()
|
|
assert_equal(chain_height, 200)
|
|
node0_address = self.nodes[0].getnewaddress()
|
|
|
|
# Coinbase at height chain_height-100+1 ok in mempool, should
|
|
# get mined. Coinbase at height chain_height-100+2 is
|
|
# is too immature to spend.
|
|
b = [self.nodes[0].getblockhash(n) for n in range(101, 103)]
|
|
coinbase_txids = [self.nodes[0].getblock(h)['tx'][0] for h in b]
|
|
spends_raw = [create_raw_transaction(self.nodes[0], txid, node0_address, amount=49.99) for txid in coinbase_txids]
|
|
|
|
spend_101_id = self.nodes[0].sendrawtransaction(spends_raw[0])
|
|
|
|
# coinbase at height 102 should be too immature to spend
|
|
assert_raises_rpc_error(-26,"bad-txns-premature-spend-of-coinbase", self.nodes[0].sendrawtransaction, spends_raw[1])
|
|
|
|
# mempool should have just spend_101:
|
|
assert_equal(self.nodes[0].getrawmempool(), [ spend_101_id ])
|
|
|
|
# mine a block, spend_101 should get confirmed
|
|
self.nodes[0].generate(1)
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
|
|
# ... and now height 102 can be spent:
|
|
spend_102_id = self.nodes[0].sendrawtransaction(spends_raw[1])
|
|
assert_equal(self.nodes[0].getrawmempool(), [ spend_102_id ])
|
|
|
|
if __name__ == '__main__':
|
|
MempoolSpendCoinbaseTest().main()
|