The blockchain that provides the digital content namespace for the LBRY protocol

bitcoin blockchain c-plus-plus cryptocurrency decentralized lbry

Find a file

Wladimir J. van der Laan 5f0c6a7b0e Merge #10244 : Refactor: separate gui from wallet and node `9960137` Add developer notes about blocking GUI code (Russell Yanofsky) `9a61eed` Use WalletBalances struct in Qt (Russell Yanofsky) `56f33ca` Remove direct bitcoin calls from qt/sendcoinsdialog.cpp (Russell Yanofsky) `e872c93` Remove direct bitcoin access from qt/guiutil.cpp (Russell Yanofsky) `5884558` Remove direct bitcoin calls from qt transaction table files (Russell Yanofsky) `3cab2ce` Remove direct bitcoin calls from qt/paymentserver.cpp (Russell Yanofsky) `3ec2ebc` Remove direct bitcoin calls from qt/addresstablemodel.cpp (Russell Yanofsky) `827de03` Remove direct bitcoin calls from qt/coincontroldialog.cpp (Russell Yanofsky) `a0704a8` Remove most direct bitcoin calls from qt/walletmodel.cpp (Russell Yanofsky) `90d4640` Remove direct bitcoin calls from qt/optionsdialog.cpp (Russell Yanofsky) `582daf6` Remove direct bitcoin calls from qt/rpcconsole.cpp (Russell Yanofsky) `3034a46` Remove direct bitcoin calls from qt/bantablemodel.cpp (Russell Yanofsky) `e0b66a3` Remove direct bitcoin calls from qt/peertablemodel.cpp (Russell Yanofsky) `d7c2c95` Remove direct bitcoin calls from qt/intro.cpp (Russell Yanofsky) `fe6f27e` Remove direct bitcoin calls from qt/clientmodel.cpp (Russell Yanofsky) `5fba3af` Remove direct bitcoin calls from qt/splashscreen.cpp (Russell Yanofsky) `c2f672f` Remove direct bitcoin calls from qt/utilitydialog.cpp (Russell Yanofsky) `3d619e9` Remove direct bitcoin calls from qt/bitcoingui.cpp (Russell Yanofsky) `c0f2756` Remove direct bitcoin calls from qt/optionsmodel.cpp (Russell Yanofsky) `71e0d90` Remove direct bitcoin calls from qt/bitcoin.cpp (Russell Yanofsky) `ea73b84` Add src/interface/README.md (Russell Yanofsky) Pull request description: This is a refactoring PR that does not change behavior in any way. This change: 1. Creates abstract [`Node`](https://github.com/ryanofsky/bitcoin/blob/pr/ipc-local/src/interface/node.h) and [`Wallet`](https://github.com/ryanofsky/bitcoin/blob/pr/ipc-local/src/interface/wallet.h) interfaces in [`src/interface/`](https://github.com/ryanofsky/bitcoin/tree/pr/ipc-local/src/interface) 1. Updates Qt code to call the new interfaces. This largely consists of diffs of the form: ```diff - InitLogging(); - InitParameterInteraction(); + node.initLogging(); + node.initParameterInteraction(); ``` This change allows followup PR #10102 (makes `bitcoin-qt` control `bitcoind` over an IPC socket) to work without any significant updates to Qt code. Additionally: * It provides a single place to describe the interface between GUI and daemon code. * It can make better GUI testing possible, because Node and Wallet objects have virtual methods that can be overloaded for mocking. * It can be used to help make the GUI more responsive (see https://github.com/bitcoin/bitcoin/issues/10504) Other notes: * I used python scripts [hide-globals.py](https://github.com/ryanofsky/home/blob/master/src/2017/hide-globals/hide-globals.py) and [replace-syms.py](https://github.com/ryanofsky/home/blob/master/src/2017/hide-globals/replace-syms.py) to identify all the places where Qt code was accessing libbitcoin global variables and calling functions accessing those global variables. * These changes were originally part of #10102. Thanks to @JeremyRubin for the suggestion of splitting them out. Commits: - [`ea73b84d2d` Add src/interface/README.md](`ea73b84d2d`) - [`71e0d90876` Remove direct bitcoin calls from qt/bitcoin.cpp](`71e0d90876`) - [`c0f2756be5` Remove direct bitcoin calls from qt/optionsmodel.cpp](`c0f2756be5`) - [`3d619e9d36` Remove direct bitcoin calls from qt/bitcoingui.cpp](`3d619e9d36`) - [`c2f672fb19` Remove direct bitcoin calls from qt/utilitydialog.cpp](`c2f672fb19`) - [`5fba3af21e` Remove direct bitcoin calls from qt/splashscreen.cpp](`5fba3af21e`) - [`fe6f27e6ea` Remove direct bitcoin calls from qt/clientmodel.cpp](`fe6f27e6ea`) - [`d7c2c95948` Remove direct bitcoin calls from qt/intro.cpp](`d7c2c95948`) - [`e0b66a3b7c` Remove direct bitcoin calls from qt/peertablemodel.cpp](`e0b66a3b7c`) - [`3034a462a5` Remove direct bitcoin calls from qt/bantablemodel.cpp](`3034a462a5`) - [`582daf6d22` Remove direct bitcoin calls from qt/rpcconsole.cpp](`582daf6d22`) - [`90d4640b7e` Remove direct bitcoin calls from qt/optionsdialog.cpp](`90d4640b7e`) - [`a0704a8996` Remove most direct bitcoin calls from qt/walletmodel.cpp](`a0704a8996`) - [`827de038ab` Remove direct bitcoin calls from qt/coincontroldialog.cpp](`827de038ab`) - [`3ec2ebcd9b` Remove direct bitcoin calls from qt/addresstablemodel.cpp](`3ec2ebcd9b`) - [`3cab2ce5f9` Remove direct bitcoin calls from qt/paymentserver.cpp](`3cab2ce5f9`) - [`58845587e1` Remove direct bitcoin calls from qt transaction table files](`58845587e1`) - [`e872c93ee8` Remove direct bitcoin access from qt/guiutil.cpp](`e872c93ee8`) - [`56f33ca349` Remove direct bitcoin calls from qt/sendcoinsdialog.cpp](`56f33ca349`) - [`9a61eed1fc` Use WalletBalances struct in Qt](`9a61eed1fc`) - [`9960137697` Add developer notes about blocking GUI code](`9960137697`) Tree-SHA512: 7b9eff2f37d4ea21972d7cc6a3dbe144248595d6c330524396d867f3cd2841d666cdc040fd3605af559dab51b075812402f61d628d16cf13719335c1d8bf8ed3		2018-04-05 18:19:35 +02:00
.github	Make default issue text all comments to make issues more readable	2017-11-16 11:50:56 -05:00
.tx	tx: Update transifex slug for 0.16	2018-01-24 16:35:40 +01:00
build-aux/m4	ax_boost_{chrono,unit_test_framework}.m4: take changes from upstream	2018-03-15 19:59:11 +01:00
contrib	Merge #12757 : Clarify include guard naming convention	2018-04-01 18:30:21 -04:00
depends	Merge #12625 : depends: biplist 1.0.3	2018-03-14 14:29:27 +01:00
doc	Merge #10244 : Refactor: separate gui from wallet and node	2018-04-05 18:19:35 +02:00
share	Change all python files to use Python3	2018-03-26 16:49:33 -04:00
src	Merge #10244 : Refactor: separate gui from wallet and node	2018-04-05 18:19:35 +02:00
test	Merge #11818 : I accidentally [deliberately] killed it [the ComparisonTestFramework]	2018-04-04 20:47:46 -04:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	[build] .gitignore: add QT Creator artifacts	2017-12-22 12:37:00 +01:00
.travis.yml	travis: Run verify-commits only on cron jobs	2018-03-31 10:59:59 -04:00
autogen.sh	Add MIT license to autogen.sh and share/genbuild.sh	2016-09-21 23:01:36 +00:00
configure.ac	Add --with-sanitizers option to configure	2018-03-28 12:33:04 -07:00
CONTRIBUTING.md	Docs: Improve documentation on standard communication channels	2018-03-22 12:58:57 -07:00
COPYING	[Trivial] Update license year range to 2018	2018-01-01 04:33:09 +09:00
INSTALL.md	Update INSTALL landing redirection notice for build instructions.	2016-10-06 12:27:23 +13:00
libbitcoinconsensus.pc.in	Unify package name to as few places as possible without major changes	2015-12-14 02:11:10 +00:00
Makefile.am	make clean removes src/qt/moc_ files	2018-04-03 15:04:35 +02:00
README.md	Docs: Improve documentation on standard communication channels	2018-03-22 12:58:57 -07:00

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoin.org/en/download, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.