LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Packages Projects Releases 32 Wiki Activity
lbrycrd/src/rpc
History
Wladimir J. van der Laan 61a044a86a
Merge #13491: Improve handling of INVALID in IsMine 
bb582a59c Add P2WSH destination helper and use it instead of manual hashing (Pieter Wuille)
eaba1c111 Add additional unit tests for invalid IsMine combinations (Pieter Wuille)
e6b9730c4 Do not expose invalidity from IsMine (Pieter Wuille)

Pull request description:

  This improves the handling of INVALID in IsMine:
  * Extra INVALID conditions were added to `IsMine` (following https://github.com/bitcoin/bitcoin/pull/13142/files#r185349057), but these were untested. Add unit tests for them.
  * In https://github.com/bitcoin/bitcoin/pull/13142#issuecomment-386396975 it was suggested to merge `isInvalid` into the return status. This PR takes a different approach, and removes the `isInvalid` entirely. It was only ever used inside tests, as normal users of IsMine don't care about the reason for non-mine-ness, only whether it is or not. As the unit tests are extensive enough, it seems sufficient to have a black box text (with tests for both compressed and uncompressed keys).

  Some addition code simplification is done as well.

Tree-SHA512: 3267f8846f3fa4e994f57504b155b0e1bbdf13808c4c04dab7c6886c2c0b88716169cee9c5b350513297e0ca2a00812e3401acf30ac9cde5d892f9fb59ad7fef
2018-07-04 11:36:42 +02:00
..
blockchain.cpp cleanup: avoid hidden copies in range-for loops 2018-06-15 13:40:00 -04:00
blockchain.h Drop the chain argument to GetDifficulty 2018-05-20 22:19:42 -07:00
client.cpp Merge #13060: [wallet] [rpc] Remove getlabeladdress RPC 2018-06-11 15:21:24 +02:00
client.h Fix missing or inconsistent include guards 2018-03-22 16:23:04 +01:00
mining.cpp Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock 2018-06-19 09:25:17 +02:00
mining.h scripted-diff: Replace #include "" with #include <> (ryanofsky) 2017-11-16 08:23:01 +13:00
misc.cpp Delete double semicolon in wallet.cpp and misc.cpp 2018-07-02 10:10:27 +02:00
net.cpp scripted-diff: Avoid temporary copies when looping over std::map 2018-06-11 13:12:55 -07:00
protocol.cpp scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) 2018-02-10 10:05:07 -05:00
protocol.h rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section 2018-04-27 09:19:09 +02:00
rawtransaction.cpp Add P2WSH destination helper and use it instead of manual hashing 2018-06-17 19:44:50 -07:00
rawtransaction.h Declare CMutableTransaction a struct in rawtransaction.h 2018-02-20 14:16:37 -08:00
register.h Fix missing or inconsistent include guards 2018-03-22 16:23:04 +01:00
server.cpp Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings} 2018-05-14 08:46:54 -04:00
server.h Merge #12757: Clarify include guard naming convention 2018-04-01 18:30:21 -04:00
util.cpp Merge #12542: Remove redundant includes. Conform to header include guidelines. 2018-03-16 16:59:27 -07:00
util.h Remove redundant includes. Conform to header include guidelines. 2018-02-27 22:30:40 +01:00