lbrycrd/src/wallet
Wladimir J. van der Laan 61a044a86a
Merge #13491: Improve handling of INVALID in IsMine
bb582a59c Add P2WSH destination helper and use it instead of manual hashing (Pieter Wuille)
eaba1c111 Add additional unit tests for invalid IsMine combinations (Pieter Wuille)
e6b9730c4 Do not expose invalidity from IsMine (Pieter Wuille)

Pull request description:

  This improves the handling of INVALID in IsMine:
  * Extra INVALID conditions were added to `IsMine` (following https://github.com/bitcoin/bitcoin/pull/13142/files#r185349057), but these were untested. Add unit tests for them.
  * In https://github.com/bitcoin/bitcoin/pull/13142#issuecomment-386396975 it was suggested to merge `isInvalid` into the return status. This PR takes a different approach, and removes the `isInvalid` entirely. It was only ever used inside tests, as normal users of IsMine don't care about the reason for non-mine-ness, only whether it is or not. As the unit tests are extensive enough, it seems sufficient to have a black box text (with tests for both compressed and uncompressed keys).

  Some addition code simplification is done as well.

Tree-SHA512: 3267f8846f3fa4e994f57504b155b0e1bbdf13808c4c04dab7c6886c2c0b88716169cee9c5b350513297e0ca2a00812e3401acf30ac9cde5d892f9fb59ad7fef
2018-07-04 11:36:42 +02:00
..
test Use bracket syntax includes ("#include <foo.h>") 2018-06-06 11:09:05 +02:00
coincontrol.h Make coincontrol use IsSolvable to determine solvability 2018-05-03 11:01:57 -07:00
coinselection.cpp Add missing newlines to LogPrint debug logging 2018-05-02 15:14:04 +02:00
coinselection.h Fix missing or inconsistent include guards 2018-03-22 16:23:04 +01:00
crypter.cpp Merge #11403: SegWit wallet support 2018-01-10 20:55:41 -10:00
crypter.h tests: Avoid test suite name collision in wallet crypto_tests 2018-04-06 16:29:14 +02:00
db.cpp bugfix: Remove dangling wallet env instance 2018-06-18 16:35:39 +01:00
db.h scripted-diff: Rename wallet database classes 2018-04-07 11:48:27 -05:00
feebumper.cpp Merge #13011: Cache witness hash in CTransaction 2018-05-23 19:26:18 +02:00
feebumper.h feebumper: Use PreconditionChecks to determine bump eligibility 2018-01-29 18:31:33 -05:00
fees.cpp wallet: Make fee settings non-static members 2018-04-23 10:49:21 -04:00
fees.h wallet: Make fee settings non-static members 2018-04-23 10:49:21 -04:00
init.cpp cleanup: avoid hidden copies in range-for loops 2018-06-15 13:40:00 -04:00
rpcdump.cpp Fix parameter count check for importpubkey. 2018-06-20 00:34:38 +03:00
rpcwallet.cpp Merge #13498: [wallet] Fixups from account API deprecation 2018-06-26 16:46:49 -07:00
rpcwallet.h wallet: Use shared pointer to retain wallet instance 2018-05-22 16:56:20 +01:00
wallet.cpp Merge #13491: Improve handling of INVALID in IsMine 2018-07-04 11:36:42 +02:00
wallet.h Merge #13111: Add unloadwallet RPC 2018-06-21 16:24:31 +02:00
walletdb.cpp wallet: Use shared pointer to retain wallet instance 2018-05-22 16:56:20 +01:00
walletdb.h [refactor] manually change remaining instances of master key to seed. 2018-05-19 11:21:15 -04:00
walletutil.cpp Don't allow relative -walletdir paths 2018-01-18 15:09:27 -05:00
walletutil.h Fix missing or inconsistent include guards 2018-03-22 16:23:04 +01:00