LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/test/lint
History
Wladimir J. van der Laan 709a15b0a6
Merge #14088: tests: Don't assert(...) with side effects 
ca1a093127 Add regression test: Don't assert(...) with side effects (practicalswift)
4c3c9c3869 Don't assert(...) with side effects (practicalswift)

Pull request description:

  Don't `assert(...)` with side effects.

  From the developer notes:

  > **Assertions should not have side-effects**
  >
  > Rationale: Even though the source code is set to refuse to compile with assertions disabled, having side-effects in assertions is unexpected and makes the code harder to understand

  These assertions were introduced quite recently (in #14069 which was merged two days ago) and since this is a recurring thing (see #13534 – "Don't assert(foo()) where foo() has side effects" from May) I added a simple regression test for the most obvious common side effect.

Tree-SHA512: be65db9d8d5d0f5752152ba73fe3fbb0531880f156d3cd7dfdf1752709979b63214e46ae64b1adbe1e09fa121278f4087f4ae49bff16cf8f5aec16ea6bde3650
2018-08-31 15:00:15 +02:00
..
check-doc.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
check-rpc-mappings.py Merge #13707: tests: Add usage note to check-rpc-mappings.py 2018-08-25 22:41:33 +02:00
commit-script-check.sh Add "export LC_ALL=C" to all shell scripts 2018-06-14 15:27:52 +02:00
git-subtree-check.sh Add "export LC_ALL=C" to all shell scripts 2018-06-14 15:27:52 +02:00
lint-all.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-assertions.sh Add regression test: Don't assert(...) with side effects 2018-08-28 14:28:14 +02:00
lint-circular-dependencies.sh lint: Add linter for circular dependencies 2018-07-18 09:11:26 -04:00
lint-filenames.sh Merge #13496: Test: Harden lint-filenames.sh 2018-06-24 18:39:27 +02:00
lint-format-strings.py Make format string linter understand basic template parameter syntax 2018-08-10 17:28:59 +02:00
lint-format-strings.sh Add linting of WalletLogPrintf(...) format strings 2018-08-07 14:57:54 +02:00
lint-include-guards.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-includes.sh Merge #13671: Remove the boost/algorithm/string/case_conv.hpp dependency 2018-08-29 14:59:49 +02:00
lint-locale-dependence.sh Removes the Boost case_conv.hpp dependency. 2018-08-28 18:42:53 +02:00
lint-logs.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-python-shebang.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-python-utf8-encoding.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-python.sh tests: Use explicit imports 2018-08-13 14:13:39 +02:00
lint-qt.sh test: Add lint to prevent SIGNAL/SLOT connect style 2018-08-21 09:43:55 +01:00
lint-shell-locale.sh use export LC_ALL=C.UTF-8 2018-08-27 12:23:25 +02:00
lint-shell.sh fix locale for lint-shell 2018-08-02 14:46:05 +02:00
lint-tests.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-whitespace.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
README.md test: Move linters to test/lint, add readme 2018-05-24 12:02:15 -04:00

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.