lbrycrd/src/wallet
Wladimir J. van der Laan 77ba4bf960
Merge #10368: [wallet] Remove helper conversion operator from wallet
5a5e4e9 [wallet] Remove CTransaction&() helper conversion operator from wallet implementation. (Karl-Johan Alm)

Pull request description:

  The `CTransaction&()` operator in `CMerkleTx` makes conversion into `CTransaction`s transparent, but was marked as to-be-removed in favor of explicitly getting the `tx` ivar, presumably as the operator can lead to ambiguous behavior and makes the code harder to follow.

  This PR removes the operator and adapts callers. This includes some cases of `static_cast<CTransaction>(wtx)` → `*wtx.tx`, which is definitely an improvement.

Tree-SHA512: 95856fec7194d6a79615ea1c322abfcd6bcedf6ffd0cfa89bbdd332ce13035fa52dd4b828d20df673072dde1be64b79c513529a6f422dd5f0961ce722a32d56a
2017-11-09 14:23:13 +01:00
..
test Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
coincontrol.h Make QT fee displays use GetMinimumFee instead of estimateSmartFee 2017-07-14 23:41:37 -04:00
crypter.cpp Changing &vec[0] to vec.data(), what 9804 missed 2017-09-08 10:36:26 +12:00
crypter.h Merge #11107: Fix races in AppInitMain and others with lock and atomic bools 2017-10-05 15:03:36 +02:00
db.cpp Merge #11376: Ensure backupwallet fails when attempting to backup to source file 2017-11-01 12:27:02 -04:00
db.h Refactor: Modernize disallowed copy constructors/assignment 2017-09-16 13:06:05 +03:00
feebumper.cpp Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
feebumper.h Refactor to use CoinControl in GetMinimumFee and FeeBumper 2017-07-14 23:10:58 -04:00
fees.cpp MOVEONLY: Fee functions wallet/wallet.cpp -> wallet/fees.cpp 2017-08-14 11:19:38 -04:00
fees.h Move some static functions out of wallet.h/cpp 2017-08-14 11:19:38 -04:00
init.cpp Fix -disablewallet default value 2017-11-07 19:13:38 +00:00
init.h [trivial] fixup comment for VerifyWallets() 2017-09-07 16:22:11 -07:00
rpcdump.cpp Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
rpcwallet.cpp Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
rpcwallet.h [wallet] Add RegisterWalletRPC() function to wallet/init.cpp 2017-09-07 16:21:26 -07:00
wallet.cpp Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
wallet.h Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
walletdb.cpp Merge #10368: [wallet] Remove helper conversion operator from wallet 2017-11-09 14:23:13 +01:00
walletdb.h Refactor: Modernize disallowed copy constructors/assignment 2017-09-16 13:06:05 +03:00