d1d54ae6a3
cead28b[docs] Add release notes for deprecated 'account' API (John Newbery)72c9575[wallet] [tests] Add tests for accounts/labels APIs (John Newbery)109e05d[wallet] [rpc] Deprecate wallet 'account' API (John Newbery)3576ab1[wallet] [rpc] Deprecate account RPC methods (John Newbery)3db1ba0[tests] Set -deprecatedrpc=accounts in tests (John Newbery)4e671f0[tests] Rename rpc_listtransactions.py to wallet_listtransactions.py (John Newbery)a28b907[wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table (John Newbery) Pull request description: Deprecate all accounts functionality and make it only accessible by using `-deprecatedrpc=accounts`. Accounts specific RPCs, account arguments, and account related results all require the `-deprecatedrpc=accunts` startup option now in order to see account things. Several wallet functional tests use the accounts system. Those tests are unchanged, except to start the nodes with `-deprecatedrpc=accounts`. We can slowly migrate those tests to use the 'label' API instead of the 'account' API before accounts are fully removed. Tree-SHA512: 89f4ae2fe6de4a1422f1817b0997ae22d63ab5a1a558362ce923a3871f3e42963405d6573c69c27f1764679cdee5b51bf52202cc407f1361bfd8066d652f3f37
115 lines
4.5 KiB
Python
Executable file
115 lines
4.5 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the importprunedfunds and removeprunedfunds RPCs."""
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import *
|
|
|
|
class ImportPrunedFundsTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 2
|
|
self.extra_args = [['-deprecatedrpc=accounts']] * 2
|
|
|
|
def run_test(self):
|
|
self.log.info("Mining blocks...")
|
|
self.nodes[0].generate(101)
|
|
|
|
self.sync_all()
|
|
|
|
# address
|
|
address1 = self.nodes[0].getnewaddress()
|
|
# pubkey
|
|
address2 = self.nodes[0].getnewaddress()
|
|
# privkey
|
|
address3 = self.nodes[0].getnewaddress()
|
|
address3_privkey = self.nodes[0].dumpprivkey(address3) # Using privkey
|
|
|
|
#Check only one address
|
|
address_info = self.nodes[0].getaddressinfo(address1)
|
|
assert_equal(address_info['ismine'], True)
|
|
|
|
self.sync_all()
|
|
|
|
#Node 1 sync test
|
|
assert_equal(self.nodes[1].getblockcount(),101)
|
|
|
|
#Address Test - before import
|
|
address_info = self.nodes[1].getaddressinfo(address1)
|
|
assert_equal(address_info['iswatchonly'], False)
|
|
assert_equal(address_info['ismine'], False)
|
|
|
|
address_info = self.nodes[1].getaddressinfo(address2)
|
|
assert_equal(address_info['iswatchonly'], False)
|
|
assert_equal(address_info['ismine'], False)
|
|
|
|
address_info = self.nodes[1].getaddressinfo(address3)
|
|
assert_equal(address_info['iswatchonly'], False)
|
|
assert_equal(address_info['ismine'], False)
|
|
|
|
#Send funds to self
|
|
txnid1 = self.nodes[0].sendtoaddress(address1, 0.1)
|
|
self.nodes[0].generate(1)
|
|
rawtxn1 = self.nodes[0].gettransaction(txnid1)['hex']
|
|
proof1 = self.nodes[0].gettxoutproof([txnid1])
|
|
|
|
txnid2 = self.nodes[0].sendtoaddress(address2, 0.05)
|
|
self.nodes[0].generate(1)
|
|
rawtxn2 = self.nodes[0].gettransaction(txnid2)['hex']
|
|
proof2 = self.nodes[0].gettxoutproof([txnid2])
|
|
|
|
txnid3 = self.nodes[0].sendtoaddress(address3, 0.025)
|
|
self.nodes[0].generate(1)
|
|
rawtxn3 = self.nodes[0].gettransaction(txnid3)['hex']
|
|
proof3 = self.nodes[0].gettxoutproof([txnid3])
|
|
|
|
self.sync_all()
|
|
|
|
#Import with no affiliated address
|
|
assert_raises_rpc_error(-5, "No addresses", self.nodes[1].importprunedfunds, rawtxn1, proof1)
|
|
|
|
balance1 = self.nodes[1].getbalance("", 0, True)
|
|
assert_equal(balance1, Decimal(0))
|
|
|
|
#Import with affiliated address with no rescan
|
|
self.nodes[1].importaddress(address2, "add2", False)
|
|
self.nodes[1].importprunedfunds(rawtxn2, proof2)
|
|
balance2 = self.nodes[1].getbalance("add2", 0, True)
|
|
assert_equal(balance2, Decimal('0.05'))
|
|
|
|
#Import with private key with no rescan
|
|
self.nodes[1].importprivkey(privkey=address3_privkey, label="add3", rescan=False)
|
|
self.nodes[1].importprunedfunds(rawtxn3, proof3)
|
|
balance3 = self.nodes[1].getbalance("add3", 0, False)
|
|
assert_equal(balance3, Decimal('0.025'))
|
|
balance3 = self.nodes[1].getbalance("*", 0, True)
|
|
assert_equal(balance3, Decimal('0.075'))
|
|
|
|
#Addresses Test - after import
|
|
address_info = self.nodes[1].getaddressinfo(address1)
|
|
assert_equal(address_info['iswatchonly'], False)
|
|
assert_equal(address_info['ismine'], False)
|
|
address_info = self.nodes[1].getaddressinfo(address2)
|
|
assert_equal(address_info['iswatchonly'], True)
|
|
assert_equal(address_info['ismine'], False)
|
|
address_info = self.nodes[1].getaddressinfo(address3)
|
|
assert_equal(address_info['iswatchonly'], False)
|
|
assert_equal(address_info['ismine'], True)
|
|
|
|
#Remove transactions
|
|
assert_raises_rpc_error(-8, "Transaction does not exist in wallet.", self.nodes[1].removeprunedfunds, txnid1)
|
|
|
|
balance1 = self.nodes[1].getbalance("*", 0, True)
|
|
assert_equal(balance1, Decimal('0.075'))
|
|
|
|
self.nodes[1].removeprunedfunds(txnid2)
|
|
balance2 = self.nodes[1].getbalance("*", 0, True)
|
|
assert_equal(balance2, Decimal('0.025'))
|
|
|
|
self.nodes[1].removeprunedfunds(txnid3)
|
|
balance3 = self.nodes[1].getbalance("*", 0, True)
|
|
assert_equal(balance3, Decimal('0.0'))
|
|
|
|
if __name__ == '__main__':
|
|
ImportPrunedFundsTest().main()
|