bffb35f876
68400d8b96 tests: Use explicit imports (practicalswift)
Pull request description:
Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports.
Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools.
An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports.
Before this commit:
```
$ contrib/devtools/lint-python.sh | head -10
./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names
./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util
$
```
After this commit:
```
$ contrib/devtools/lint-python.sh | head -10
$
```
Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
68 lines
2.8 KiB
Python
Executable file
68 lines
2.8 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test resurrection of mined transactions when the blockchain is re-organized."""
|
|
|
|
from test_framework.blocktools import create_raw_transaction
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
|
|
class MempoolCoinbaseTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def run_test(self):
|
|
node0_address = self.nodes[0].getnewaddress()
|
|
# Spend block 1/2/3's coinbase transactions
|
|
# Mine a block.
|
|
# Create three more transactions, spending the spends
|
|
# Mine another block.
|
|
# ... make sure all the transactions are confirmed
|
|
# Invalidate both blocks
|
|
# ... make sure all the transactions are put back in the mempool
|
|
# Mine a new block
|
|
# ... make sure all the transactions are confirmed again.
|
|
|
|
b = [self.nodes[0].getblockhash(n) for n in range(1, 4)]
|
|
coinbase_txids = [self.nodes[0].getblock(h)['tx'][0] for h in b]
|
|
spends1_raw = [create_raw_transaction(self.nodes[0], txid, node0_address, amount=49.99) for txid in coinbase_txids]
|
|
spends1_id = [self.nodes[0].sendrawtransaction(tx) for tx in spends1_raw]
|
|
|
|
blocks = []
|
|
blocks.extend(self.nodes[0].generate(1))
|
|
|
|
spends2_raw = [create_raw_transaction(self.nodes[0], txid, node0_address, amount=49.98) for txid in spends1_id]
|
|
spends2_id = [self.nodes[0].sendrawtransaction(tx) for tx in spends2_raw]
|
|
|
|
blocks.extend(self.nodes[0].generate(1))
|
|
|
|
# mempool should be empty, all txns confirmed
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
for txid in spends1_id+spends2_id:
|
|
tx = self.nodes[0].gettransaction(txid)
|
|
assert(tx["confirmations"] > 0)
|
|
|
|
# Use invalidateblock to re-org back; all transactions should
|
|
# end up unconfirmed and back in the mempool
|
|
for node in self.nodes:
|
|
node.invalidateblock(blocks[0])
|
|
|
|
# mempool should be empty, all txns confirmed
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set(spends1_id+spends2_id))
|
|
for txid in spends1_id+spends2_id:
|
|
tx = self.nodes[0].gettransaction(txid)
|
|
assert(tx["confirmations"] == 0)
|
|
|
|
# Generate another block, they should all get mined
|
|
self.nodes[0].generate(1)
|
|
# mempool should be empty, all txns confirmed
|
|
assert_equal(set(self.nodes[0].getrawmempool()), set())
|
|
for txid in spends1_id+spends2_id:
|
|
tx = self.nodes[0].gettransaction(txid)
|
|
assert(tx["confirmations"] > 0)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MempoolCoinbaseTest().main()
|