lbrycrd/src/qt
fanquake a953429a0e
Merge #16822: gui: Create wallet menu option follow-ups
cad3ab5db8 gui: fix autofocus in CreateWalletActivity::askPassphrase() (Jon Atack)
539d9403af gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog (Jon Atack)
43aa9b0d79 gui: rename encrypt(), blank(), and askPasshprase() (Jon Atack)

Pull request description:

  Closes #16820. The wallet [name escaping issue](https://github.com/bitcoin/bitcoin/pull/15450#pullrequestreview-282297760) in that issue predates #15450 and is fixed by #16826.

  - [x]  rename encrypt() to encryptWallet(), and blank() to makeBlankWallet() // EDIT: updated to
          isEncryptWalletChecked()
          isDisablePrivateKeysChecked()
          isMakeBlankWalletChecked()
  - [x]  fix naming of askPasshprase() to askPassphrase()
  - [x]  fix passphrase labels and tooltip in createwalletdialog.ui and askpassphrasedialog.ui
  - [x]  fix grammar of labels in askpassphrase dialog and WalletController::closeWallet
  - [x]  fix autofocus in CreateWalletActivity::askPassphrase()

  Squashed down to three commits.

  Reviewers, to test manually: build, launch the gui wallet, and look at labels/tooltips/focus with the create wallet, encrypt wallet, change password, and close wallet commands.

ACKs for top commit:
  jb55:
    Approach ACK cad3ab5db8
  instagibbs:
    code review and tACK cad3ab5db8
  fanquake:
    ACK cad3ab5db8

Tree-SHA512: b441fbf8f8cd370dd692bac24f0d3c1b32fc7d947b6c3a2c9ba7cf0bc175a72b3460440f2f10f7632c0e8e0f8e65fe15615a30c46e2c7763bf258c504b457dd6
2019-09-16 16:52:00 +08:00
..
forms Merge #16822: gui: Create wallet menu option follow-ups 2019-09-16 16:52:00 +08:00
locale gui: Update English source translation 2019-09-02 13:42:01 +02:00
res qt: Remove menu icons 2019-08-15 13:05:10 +02:00
test Testchains: Qt: Simplify network/chain styles 2019-09-06 22:13:49 +02:00
addressbookpage.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
addressbookpage.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
addresstablemodel.cpp refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound 2019-08-22 13:43:47 +08:00
addresstablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
askpassphrasedialog.cpp gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog 2019-09-09 10:57:38 +02:00
askpassphrasedialog.h Optionally allow AskPassphraseDialog to output the passphrase 2019-09-05 20:36:57 -04:00
bantablemodel.cpp refactor: replace qStableSort with std::stable_sort 2019-08-22 13:40:51 +08:00
bantablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
bitcoin.cpp Merge #16714: gui: add prune to intro screen with smart default 2019-09-12 15:00:51 +02:00
bitcoin.h [gui] add explicit prune setter 2019-08-24 22:36:11 +02:00
bitcoin.qrc qt: Remove menu icons 2019-08-15 13:05:10 +02:00
bitcoin_locale.qrc
bitcoinaddressvalidator.cpp
bitcoinaddressvalidator.h
bitcoinamountfield.cpp qt: Add TextWidth() wrapper 2019-08-23 21:27:50 +03:00
bitcoinamountfield.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
bitcoingui.cpp gui: fix autofocus in CreateWalletActivity::askPassphrase() 2019-09-09 11:04:32 +02:00
bitcoingui.h Add Create Wallet menu action 2019-09-05 20:36:57 -04:00
bitcoinstrings.cpp gui: Update English source translation 2019-09-02 13:42:01 +02:00
bitcoinunits.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
bitcoinunits.h
clientmodel.cpp qt: Assert QMetaObject::invokeMethod result 2019-07-08 21:30:25 +01:00
clientmodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
coincontroldialog.cpp Merge #16128: Delete error-prone CScript constructor only used with FindAndDelete 2019-07-08 20:45:12 +02:00
coincontroldialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
coincontroltreewidget.cpp
coincontroltreewidget.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
createwalletdialog.cpp gui: rename encrypt(), blank(), and askPasshprase() 2019-09-09 10:56:38 +02:00
createwalletdialog.h gui: rename encrypt(), blank(), and askPasshprase() 2019-09-09 10:56:38 +02:00
csvmodelwriter.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
csvmodelwriter.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
editaddressdialog.cpp Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
editaddressdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
guiconstants.h Expose wallet creation to the GUI via WalletController 2019-09-05 20:36:57 -04:00
guiutil.cpp Testchains: Generic selection with -chain=<str> in addition of -testnet and -regtest 2019-09-06 22:05:33 +02:00
guiutil.h qt: Add TextWidth() wrapper 2019-08-23 21:27:50 +03:00
intro.cpp [gui] intro: enable pruning by default unless disk is big 2019-08-24 22:41:32 +02:00
intro.h [gui] intro: add prune preference 2019-08-24 22:41:32 +02:00
macdockiconhandler.h
macdockiconhandler.mm qt: Replace objc_msgSend with native syntax 2019-08-31 12:25:34 +03:00
macnotificationhandler.h
macnotificationhandler.mm Refactoring with QString::toNSString 2018-12-16 20:29:56 +02:00
macos_appnap.h
macos_appnap.mm
main.cpp Refactor out translation.h 2019-07-24 16:32:53 +03:00
Makefile build: add stub makefiles for easier subdir builds 2014-06-05 16:05:43 -04:00
modaloverlay.cpp Qt: Fix update headers-count 2019-01-04 08:52:27 -10:00
modaloverlay.h Qt: Fix update headers-count 2019-01-04 08:52:27 -10:00
networkstyle.cpp Testchains: Qt: Simplify network/chain styles 2019-09-06 22:13:49 +02:00
networkstyle.h Testchains: Qt: Simplify network/chain styles 2019-09-06 22:13:49 +02:00
notificator.cpp Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
notificator.h Remove misplaced Q_UNUSED and others enhancements 2018-12-20 01:06:37 +02:00
openuridialog.cpp
openuridialog.h
optionsdialog.cpp scripted-diff: Avoid passing PACKAGE_NAME for translation 2019-06-26 11:01:57 -04:00
optionsdialog.h
optionsmodel.cpp [gui] add explicit prune setter 2019-08-24 22:36:11 +02:00
optionsmodel.h [gui] add explicit prune setter 2019-08-24 22:36:11 +02:00
overviewpage.cpp Merge #14879: qt: Add warning messages to the debug window 2019-08-28 16:03:09 -04:00
overviewpage.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
paymentrequest.proto
paymentrequestplus.cpp
paymentrequestplus.h
paymentserver.cpp Qt: advise users not to switch wallets when opening a BIP70 URI. 2019-09-12 14:11:34 +03:00
paymentserver.h
peertablemodel.cpp refactor: replace qStableSort with std::stable_sort 2019-08-22 13:40:51 +08:00
peertablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
platformstyle.cpp gui: remove unused PlatformStyle::TextColorIcon 2019-08-22 14:50:29 +08:00
platformstyle.h gui: remove unused PlatformStyle::TextColorIcon 2019-08-22 14:50:29 +08:00
qrimagewidget.cpp GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
qrimagewidget.h GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
qvalidatedlineedit.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
qvalidatedlineedit.h
qvaluecombobox.cpp
qvaluecombobox.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
README.md
receivecoinsdialog.cpp qt: Remove obsolete QModelIndex::child() 2019-08-25 08:16:14 +03:00
receivecoinsdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
receiverequestdialog.cpp Make reasoning about dependencies easier by not including unused dependencies 2019-06-02 17:15:23 +02:00
receiverequestdialog.h GUI: Move QRImageWidget to its own file-pair 2019-05-02 12:18:18 +00:00
recentrequeststablemodel.cpp refactor: replace qSort with std::sort 2019-08-22 13:42:44 +08:00
recentrequeststablemodel.h qt: Remove obsolete QModelIndex::child() 2019-08-25 08:16:14 +03:00
rpcconsole.cpp Merge #16706: qt: Replace deprecated QSignalMapper by lambda expressions 2019-08-29 15:59:29 +02:00
rpcconsole.h Merge #14879: qt: Add warning messages to the debug window 2019-08-28 16:03:09 -04:00
sendcoinsdialog.cpp HTML escape address labels in more dialogs and notifications 2019-09-08 16:40:37 -04:00
sendcoinsdialog.h Make SendConfirmationDialog fully fledged 2019-04-24 21:56:10 +03:00
sendcoinsentry.cpp Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
sendcoinsentry.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
signverifymessagedialog.cpp Replace CScriptID and CKeyID in CTxDestination with dedicated types 2019-04-29 10:15:23 -04:00
signverifymessagedialog.h
splashscreen.cpp qt: Replace obsolete functions of QDesktopWidget 2019-08-25 08:46:32 +03:00
splashscreen.h
trafficgraphwidget.cpp Add antialiasing to traffic graph widget 2019-07-02 07:26:40 +02:00
trafficgraphwidget.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactiondesc.cpp Move ismine to wallet module 2019-06-19 18:06:30 -04:00
transactiondesc.h
transactiondescdialog.cpp
transactiondescdialog.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionfilterproxy.cpp
transactionfilterproxy.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionrecord.cpp Move ismine to wallet module 2019-06-19 18:06:30 -04:00
transactionrecord.h Don't label transactions "Open" while catching up 2019-01-03 00:10:24 +02:00
transactiontablemodel.cpp refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound 2019-08-22 13:43:47 +08:00
transactiontablemodel.h Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant) 2019-01-13 03:25:14 -08:00
transactionview.cpp qt: Remove QSignalMapper from TransactionView 2019-08-25 09:12:38 +03:00
transactionview.h qt: Remove QSignalMapper from TransactionView 2019-08-25 09:12:38 +03:00
utilitydialog.cpp scripted-diff: Avoid passing PACKAGE_NAME for translation 2019-06-26 11:01:57 -04:00
utilitydialog.h Replace remaining 0 with nullptr in Qt code 2019-01-13 03:25:14 -08:00
walletcontroller.cpp gui: fix autofocus in CreateWalletActivity::askPassphrase() 2019-09-09 11:04:32 +02:00
walletcontroller.h gui: rename encrypt(), blank(), and askPasshprase() 2019-09-09 10:56:38 +02:00
walletframe.cpp gui: Drop unused return values in WalletFrame 2019-02-22 16:26:09 +00:00
walletframe.h gui: Drop unused return values in WalletFrame 2019-02-22 16:26:09 +00:00
walletmodel.cpp Get rid of PendingWalletTx class. 2019-07-18 12:06:23 -04:00
walletmodel.h Give WalletModel::UnlockContext move semantics 2019-05-09 18:07:33 -07:00
walletmodeltransaction.cpp Get rid of PendingWalletTx class. 2019-07-18 12:06:23 -04:00
walletmodeltransaction.h Get rid of PendingWalletTx class. 2019-07-18 12:06:23 -04:00
walletview.cpp HTML escape address labels in more dialogs and notifications 2019-09-08 16:40:37 -04:00
walletview.h
winshutdownmonitor.cpp Use qInfo() if no error occurs 2019-06-21 20:22:13 +03:00
winshutdownmonitor.h

This directory contains the BitcoinQT graphical user interface (GUI). It uses the cross-platform framework Qt.

The current precise version for Qt 5 is specified in qt.mk.

Compile and run

See build instructions (macOS, Windows, Unix, etc).

To run:

./src/qt/bitcoin-qt

Files and directories

forms

Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.

locale

Contains translations. They are periodically updated. The process is described here.

res

Resources such as the icon.

test

Tests.

bitcoingui.(h/cpp)

Represents the main window of the Bitcoin UI.

*model.(h/cpp)

The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.

ClientModel is used by the main application bitcoingui and several models like peertablemodel.

*page.(h/cpp)

A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.

*dialog.(h/cpp)

Various dialogs, e.g. to open a URL. Inherit from QDialog.

paymentserver.(h/cpp)

Used to process BIP21 and BIP70 (see https://github.com/bitcoin/bitcoin/pull/11622) payment URI / requests. Also handles URI based application switching (e.g. when following a bitcoin:... link from a browser).

walletview.(h/cpp)

Represents the view to a single wallet.

Other .h/cpp files

  • UI elements like BitcoinAmountField, which inherit from QWidget.
  • bitcoinstrings.cpp: automatically generated
  • bitcoinunits.(h/cpp): BTC / mBTC / etc handling
  • callback.h
  • guiconstants.h: UI colors, app name, etc
  • guiutil.h: several helper functions
  • macdockiconhandler.(h/mm): macOS dock icon handler
  • macnotificationhandler.(h/mm): display notifications in macOS

Contribute

See CONTRIBUTING.md for general guidelines. Specifically for Qt:

Using Qt Creator as IDE

You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.

Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.

Instructions for macOS:

  1. Make sure you installed everything through Homebrew mentioned in the macOS build instructions
  2. Use ./configure with the --enable-debug flag
  3. In Qt Creator do "New Project" -> Import Project -> Import Existing Project
  4. Enter "bitcoin-qt" as project name, enter src/qt as location
  5. Leave the file selection as it is
  6. Confirm the "summary page"
  7. In the "Projects" tab select "Manage Kits..."
  8. Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
  9. Select LLDB as debugger (you might need to set the path to your installation)
  10. Start debugging with Qt Creator (you might need to the executable to "bitcoin-qt" under "Run", which is where you can also add command line arguments)