lbrycrd

History

Pieter Wuille c17f11f7b4 Merge #10773 : Shell script cleanups `13a81b19d` Add quotes to variable assignment (as requested by @TheBlueMatt) (practicalswift) `683b9d280` Fix valid path output (practicalswift) `193c2fb4c` Use bash instead of POSIX sh. POSIX sh does not support arrays. (practicalswift) `80f5f28d3` Fix incorrect quoting of quotes (the previous quotes had no effect beyond unquoting) (practicalswift) `564a172df` Add required space to [[ -n "$1" ]] (previously [[ -n"$1" ]]) (practicalswift) `1e44ae0e1` Add error handling: exit if cd fails (practicalswift) `b9e79ab41` Remove "\n" from echo argument. echo does not support escape sequences. (practicalswift) `f6b3382fa` Remove unused variables (practicalswift) Pull request description: Shell script cleanups: * Add required space to `[ -n ]`. * Avoid quote within quote. * Exit if `cd` fails. * Remove `\n` which is not handled by `echo`. * ~~Remove redundant `$` in arithmetic variable expression.~~ * ~~Use `$(command)` instead of legacy form `` `command` ``.~~ * Arrays are not supported in POSIX `sh`. Use `bash` when arrays are used. * ~~`[ foo -a bar ]` is not well defined, use `[ foo ] && [ bar ]` instead.~~ * ~~`[ foo -o bar ]` is not well defined, use `[ foo ] \|\| [ bar ]` instead.~~ Tree-SHA512: 80f6ded58bce625b15b4da30d69d2714c633e184e62b21ed67d2c58e2ebaa08b4147593324012694d02bf4f1f252844cdff2fd1cf5e817ddb07e2777db7a6390		2017-12-04 15:52:11 -08:00
..
allow-revsig-commits	Add Pieter's old signed commits to revsig-commits	2017-02-27 20:24:20 -05:00
gpg.sh	[verify-commits] Allow revoked keys to expire	2017-10-20 16:35:16 -04:00
pre-push-hook.sh	[copyright] add MIT license headers to .sh scripts where missing	2016-09-11 13:36:22 -06:00
README.md	Add README for verify-commits	2016-06-09 13:58:29 -04:00
trusted-git-root	Remove keys that are no longer used for merging	2016-05-21 11:29:01 +02:00
trusted-keys	Allow any subkey in verify-commits	2017-03-04 09:41:16 -05:00
trusted-sha512-root-commit	Update trusted-sha512-root-commit for new bad tree hash	2017-03-09 09:53:19 -05:00
verify-commits.sh	Merge #10773 : Shell script cleanups	2017-12-04 15:52:11 -08:00

README.md

Tooling for verification of PGP signed commits

This is an incomplete work in progress, but currently includes a pre-push hook script (pre-push-hook.sh) for maintainers to ensure that their own commits are PGP signed (nearly always merge commits), as well as a script to verify commits against a trusted keys list.

Using verify-commits.sh safely

Remember that you can't use an untrusted script to verify itself. This means that checking out code, then running verify-commits.sh against HEAD is not safe, because the version of verify-commits.sh that you just ran could be backdoored. Instead, you need to use a trusted version of verify-commits prior to checkout to make sure you're checking out only code signed by trusted keys:

git fetch origin && \
  ./contrib/verify-commits/verify-commits.sh origin/master && \
  git checkout origin/master

Note that the above isn't a good UI/UX yet, and needs significant improvements to make it more convenient and reduce the chance of errors; pull-reqs improving this process would be much appreciated.