bfaed1ab2e
f8c249ab91
Assert CPubKey::ValidLength to the pubkey's header-relevent size (Ben Woosley)
Pull request description:
A pubkey's length is specific to its type which is indicated by its header value. GetLen returns the header-indicated length, so this change ensures that a key matches its header-indicated length.
And replace some magic values with their constant equivalents.
Tree-SHA512: b727b39a631babe0932326396fc4d796ade8ec1e37454ff0c709ae9b78ecbd0cfdf59d84089ba8415e6efa7bc180e3cd39a14ddaf0871cbac54b96851e1b7b44
197 lines
5.9 KiB
C++
197 lines
5.9 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2017 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <keystore.h>
|
|
|
|
#include <util.h>
|
|
|
|
void CBasicKeyStore::ImplicitlyLearnRelatedKeyScripts(const CPubKey& pubkey)
|
|
{
|
|
AssertLockHeld(cs_KeyStore);
|
|
CKeyID key_id = pubkey.GetID();
|
|
// We must actually know about this key already.
|
|
assert(HaveKey(key_id) || mapWatchKeys.count(key_id));
|
|
// This adds the redeemscripts necessary to detect P2WPKH and P2SH-P2WPKH
|
|
// outputs. Technically P2WPKH outputs don't have a redeemscript to be
|
|
// spent. However, our current IsMine logic requires the corresponding
|
|
// P2SH-P2WPKH redeemscript to be present in the wallet in order to accept
|
|
// payment even to P2WPKH outputs.
|
|
// Also note that having superfluous scripts in the keystore never hurts.
|
|
// They're only used to guide recursion in signing and IsMine logic - if
|
|
// a script is present but we can't do anything with it, it has no effect.
|
|
// "Implicitly" refers to fact that scripts are derived automatically from
|
|
// existing keys, and are present in memory, even without being explicitly
|
|
// loaded (e.g. from a file).
|
|
if (pubkey.IsCompressed()) {
|
|
CScript script = GetScriptForDestination(WitnessV0KeyHash(key_id));
|
|
// This does not use AddCScript, as it may be overridden.
|
|
CScriptID id(script);
|
|
mapScripts[id] = std::move(script);
|
|
}
|
|
}
|
|
|
|
bool CBasicKeyStore::GetPubKey(const CKeyID &address, CPubKey &vchPubKeyOut) const
|
|
{
|
|
CKey key;
|
|
if (!GetKey(address, key)) {
|
|
LOCK(cs_KeyStore);
|
|
WatchKeyMap::const_iterator it = mapWatchKeys.find(address);
|
|
if (it != mapWatchKeys.end()) {
|
|
vchPubKeyOut = it->second;
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
vchPubKeyOut = key.GetPubKey();
|
|
return true;
|
|
}
|
|
|
|
bool CBasicKeyStore::AddKeyPubKey(const CKey& key, const CPubKey &pubkey)
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
mapKeys[pubkey.GetID()] = key;
|
|
ImplicitlyLearnRelatedKeyScripts(pubkey);
|
|
return true;
|
|
}
|
|
|
|
bool CBasicKeyStore::HaveKey(const CKeyID &address) const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
return mapKeys.count(address) > 0;
|
|
}
|
|
|
|
std::set<CKeyID> CBasicKeyStore::GetKeys() const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
std::set<CKeyID> set_address;
|
|
for (const auto& mi : mapKeys) {
|
|
set_address.insert(mi.first);
|
|
}
|
|
return set_address;
|
|
}
|
|
|
|
bool CBasicKeyStore::GetKey(const CKeyID &address, CKey &keyOut) const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
KeyMap::const_iterator mi = mapKeys.find(address);
|
|
if (mi != mapKeys.end()) {
|
|
keyOut = mi->second;
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool CBasicKeyStore::AddCScript(const CScript& redeemScript)
|
|
{
|
|
if (redeemScript.size() > MAX_SCRIPT_ELEMENT_SIZE)
|
|
return error("CBasicKeyStore::AddCScript(): redeemScripts > %i bytes are invalid", MAX_SCRIPT_ELEMENT_SIZE);
|
|
|
|
LOCK(cs_KeyStore);
|
|
mapScripts[CScriptID(redeemScript)] = redeemScript;
|
|
return true;
|
|
}
|
|
|
|
bool CBasicKeyStore::HaveCScript(const CScriptID& hash) const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
return mapScripts.count(hash) > 0;
|
|
}
|
|
|
|
std::set<CScriptID> CBasicKeyStore::GetCScripts() const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
std::set<CScriptID> set_script;
|
|
for (const auto& mi : mapScripts) {
|
|
set_script.insert(mi.first);
|
|
}
|
|
return set_script;
|
|
}
|
|
|
|
bool CBasicKeyStore::GetCScript(const CScriptID &hash, CScript& redeemScriptOut) const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
ScriptMap::const_iterator mi = mapScripts.find(hash);
|
|
if (mi != mapScripts.end())
|
|
{
|
|
redeemScriptOut = (*mi).second;
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
static bool ExtractPubKey(const CScript &dest, CPubKey& pubKeyOut)
|
|
{
|
|
//TODO: Use Solver to extract this?
|
|
CScript::const_iterator pc = dest.begin();
|
|
opcodetype opcode;
|
|
std::vector<unsigned char> vch;
|
|
if (!dest.GetOp(pc, opcode, vch) || !CPubKey::ValidSize(vch))
|
|
return false;
|
|
pubKeyOut = CPubKey(vch);
|
|
if (!pubKeyOut.IsFullyValid())
|
|
return false;
|
|
if (!dest.GetOp(pc, opcode, vch) || opcode != OP_CHECKSIG || dest.GetOp(pc, opcode, vch))
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
bool CBasicKeyStore::AddWatchOnly(const CScript &dest)
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
setWatchOnly.insert(dest);
|
|
CPubKey pubKey;
|
|
if (ExtractPubKey(dest, pubKey)) {
|
|
mapWatchKeys[pubKey.GetID()] = pubKey;
|
|
ImplicitlyLearnRelatedKeyScripts(pubKey);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool CBasicKeyStore::RemoveWatchOnly(const CScript &dest)
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
setWatchOnly.erase(dest);
|
|
CPubKey pubKey;
|
|
if (ExtractPubKey(dest, pubKey)) {
|
|
mapWatchKeys.erase(pubKey.GetID());
|
|
}
|
|
// Related CScripts are not removed; having superfluous scripts around is
|
|
// harmless (see comment in ImplicitlyLearnRelatedKeyScripts).
|
|
return true;
|
|
}
|
|
|
|
bool CBasicKeyStore::HaveWatchOnly(const CScript &dest) const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
return setWatchOnly.count(dest) > 0;
|
|
}
|
|
|
|
bool CBasicKeyStore::HaveWatchOnly() const
|
|
{
|
|
LOCK(cs_KeyStore);
|
|
return (!setWatchOnly.empty());
|
|
}
|
|
|
|
CKeyID GetKeyForDestination(const CKeyStore& store, const CTxDestination& dest)
|
|
{
|
|
// Only supports destinations which map to single public keys, i.e. P2PKH,
|
|
// P2WPKH, and P2SH-P2WPKH.
|
|
if (auto id = boost::get<CKeyID>(&dest)) {
|
|
return *id;
|
|
}
|
|
if (auto witness_id = boost::get<WitnessV0KeyHash>(&dest)) {
|
|
return CKeyID(*witness_id);
|
|
}
|
|
if (auto script_id = boost::get<CScriptID>(&dest)) {
|
|
CScript script;
|
|
CTxDestination inner_dest;
|
|
if (store.GetCScript(*script_id, script) && ExtractDestination(script, inner_dest)) {
|
|
if (auto inner_witness_id = boost::get<WitnessV0KeyHash>(&inner_dest)) {
|
|
return CKeyID(*inner_witness_id);
|
|
}
|
|
}
|
|
}
|
|
return CKeyID();
|
|
}
|