LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/test/lint
History
MarcoFalke ae2c19f578
Merge #15655: Resolve the checkpoints <-> validation circular dependency 
418d3230f8 Resolve the checkpoints <-> validation CD. (251)

Pull request description:

  This pull request attempts to resolve the `checkpoints -> validation -> checkpoints` circular dependency.

  The circular dependency is resolved by moving the `CheckPoints::GetLastCheckpoint(const CCheckpointData& data)` function to `validation.cpp` where it used exclusively by the private function `ContextualCheckBlockHeader(const CBlockHeader& block, CValidationState& state, const CChainParams& params, const CBlockIndex* pindexPrev, int64_t nAdjustedTime)`.

ACKs for commit 418d32:
  promag:
    utACK 418d323, only `GetLastCheckpoint` usage is in `validation.cpp` and so makes sense to move it there.
  practicalswift:
    utACK 418d3230f8
  MarcoFalke:
    utACK 418d3230f8
  sipa:
    utACK 418d3230f8

Tree-SHA512: 03c3556bc192e65f5e3fa76fd545d4ee7d63d3fb06b132f7a1fa6131aa21ddd2e5b2d19e2222dfe524f422daaca30efde219bed188db8c74ff4b088876b5bc16
2019-04-19 09:34:01 -04:00
..
check-doc.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
check-rpc-mappings.py Merge #13707: tests: Add usage note to check-rpc-mappings.py 2018-08-25 22:41:33 +02:00
commit-script-check.sh scripted-diff: Run scripted-diff in subshell 2018-12-04 07:57:02 -08:00
git-subtree-check.sh Add "export LC_ALL=C" to all shell scripts 2018-06-14 15:27:52 +02:00
lint-all.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-assertions.sh Add regression test: Don't assert(...) with side effects 2018-08-28 14:28:14 +02:00
lint-circular-dependencies.sh Merge #15655: Resolve the checkpoints <-> validation circular dependency 2019-04-19 09:34:01 -04:00
lint-filenames.sh Merge #13496: Test: Harden lint-filenames.sh 2018-06-24 18:39:27 +02:00
lint-format-strings.py Merge #15534: [test] lint-format-strings: open files sequentially (fix for OS X) 2019-03-05 09:40:23 -05:00
lint-format-strings.sh Fix warnings introduced in shellcheck v0.6.0 2019-01-16 15:47:56 +01:00
lint-include-guards.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-includes.sh scripted-diff: Replace boost::bind with std::bind 2018-10-20 02:29:59 +08:00
lint-locale-dependence.sh Make PID file creating errors fatal 2019-02-02 01:07:23 +02:00
lint-logs.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-python-dead-code.sh build: Require python 3.5 2019-03-02 10:40:23 -05:00
lint-python-utf8-encoding.sh lint: Make sure we read the command line inputs using utf-8 decoding in python 2018-09-02 21:40:51 +08:00
lint-python.sh lint: Enable python linters via an array 2019-01-20 17:13:22 -08:00
lint-qt.sh test: Add lint to prevent SIGNAL/SLOT connect style 2018-08-21 09:43:55 +01:00
lint-rpc-help.sh rpc: Documentation fixups 2018-11-15 12:19:11 -05:00
lint-shebang.sh Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. 2018-12-02 16:14:21 +02:00
lint-shell-locale.sh macOS fix: Work around empty (sub)expression error when using BSD grep 2018-08-31 00:52:48 +02:00
lint-shell.sh Remove no longer needed shellcheck suppressions 2019-01-16 15:47:56 +01:00
lint-spelling.ignore-words.txt Add ignored word: mut 2018-10-16 13:34:10 +02:00
lint-spelling.sh Revert "qa: Fix codespell error and have lint-spelling error instead of warn" 2018-10-16 13:33:05 +02:00
lint-tests.sh Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
lint-whitespace.sh Replace script name with special parameter 2019-02-12 23:25:54 +02:00
README.md test: Move linters to test/lint, add readme 2018-05-24 12:02:15 -04:00

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.