lbrycrd/qa/rpc-tests
John Newbery dab804c18a Return correct error codes in fundrawtransaction().
The fundrawtransaction() RPC was returning misleading or incorrect error
codes (for example RPC_INTERNAL_ERROR when funding the transaction
failed). This commit fixes those error codes:

- RPC_INTERNAL_ERROR should not be returned for application-level
errors, only for genuine internal errors such as corrupted data.

That error code has been replaced with RPC_WALLET_ERROR.

This commit also updates the test cases to explicitly test the error code.
2017-03-07 16:45:09 -05:00
..
test_framework Merge #9602: Remove coin age priority and free transactions - implementation 2017-03-07 19:30:23 +01:00
.gitignore Python-based regression tests 2014-02-28 15:24:31 -05:00
abandonconflict.py No longer allow "free" transactions 2017-03-03 16:50:19 -05:00
assumevalid.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bip9-softforks.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bip65-cltv-p2p.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bip65-cltv.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bip68-112-113-p2p.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bip68-sequence.py Merge #9602: Remove coin age priority and free transactions - implementation 2017-03-07 19:30:23 +01:00
bipdersig-p2p.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bipdersig.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
blockchain.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
bumpfee.py Return correct error codes in bumpfee(). 2017-03-07 16:45:09 -05:00
create_cache.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
decodescript.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
disablewallet.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
forknotify.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
fundrawtransaction.py Return correct error codes in fundrawtransaction(). 2017-03-07 16:45:09 -05:00
getblocktemplate_longpoll.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
getblocktemplate_proposals.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
getchaintips.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
httpbasics.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
import-rescan.py Define 7200 second timestamp window constant 2017-03-03 13:51:41 -05:00
importmulti.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
importprunedfunds.py Return correct error codes in removeprunedfunds(). 2017-03-07 16:45:09 -05:00
invalidateblock.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
invalidblockrequest.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
invalidtxrequest.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
keypool.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
listsinceblock.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
listtransactions.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
maxblocksinflight.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
maxuploadtarget.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
mempool_limit.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
mempool_packages.py [rpc] Remove priorityDelta from prioritisetransaction 2017-03-03 16:50:19 -05:00
mempool_reorg.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
mempool_resurrect_test.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
mempool_spendcoinbase.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
merkle_blocks.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
multi_rpc.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
nodehandling.py Return correct error codes in setban(). 2017-03-07 16:45:09 -05:00
nulldummy.py [rpc] sendrawtransaction no longer bypasses minRelayTxFee 2017-02-27 11:23:51 -05:00
p2p-acceptblock.py Return correct error codes in blockchain.cpp. 2017-03-07 16:45:09 -05:00
p2p-compactblocks.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-feefilter.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-fullblocktest.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-leaktests.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-mempool.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-segwit.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-timeouts.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
p2p-versionbits-warning.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
preciousblock.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
prioritise_transaction.py [rpc] Remove priorityDelta from prioritisetransaction 2017-03-03 16:50:19 -05:00
proxy_test.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
pruning.py Return correct error codes in blockchain.cpp. 2017-03-07 16:45:09 -05:00
rawtransactions.py Return correct error codes in fundrawtransaction(). 2017-03-07 16:45:09 -05:00
README.md test: remove necessity to call create_callback_map 2015-12-04 13:15:59 +01:00
receivedby.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
reindex.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
replace-by-fee.py [rpc] Remove priorityDelta from prioritisetransaction 2017-03-03 16:50:19 -05:00
rest.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
rpcbind_test.py Merge #9577: Fix docstrings in qa tests 2017-02-23 16:39:22 +01:00
rpcnamedargs.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
segwit.py Fix segwit getblocktemplate test. 2017-02-23 18:01:37 -05:00
sendheaders.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
signmessages.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
signrawtransactions.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
smartfees.py [test] Remove priority from tests 2017-03-03 16:50:19 -05:00
txn_clone.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
txn_doublespend.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
wallet-accounts.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
wallet-dump.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
wallet-hd.py Merge #9832: [qa] assert_start_raises_init_error 2017-03-06 10:04:22 +01:00
wallet.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
walletbackup.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
zapwallettxes.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00
zmq_test.py Fix docstrings in qa tests 2017-02-23 10:31:04 -05:00

Regression tests

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for new regression tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support p2p connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, p2p tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

P2P test design notes

Mininode

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • NodeConn is the class used to connect to a bitcoind. If you implement a callback class that derives from NodeConnCB and pass that to the NodeConn object, your code will receive the appropriate callbacks when events of interest arrive.

  • You can pass the same handler to multiple NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test.

  • Call NetworkThread.start() after all NodeConn objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • RPC calls are available in p2p tests.

  • Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples: p2p-accept-block.py, maxblocksinflight.py.

Comptool

  • Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • a list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.