eb0b56b190
Remove the 'state' and 'exceptmask' from serialize.h's stream implementations, as well as related methods. As exceptmask always included 'failbit', and setstate was always called with bits = failbit, all it did was immediately raise an exception. Get rid of those variables, and replace the setstate with direct exception throwing (which also removes some dead code). As a result, good() is never reached after a failure (there are only 2 calls, one of which is in tests), and can just be replaced by !eof(). fail(), clear(n) and exceptions() are just never called. Delete them. |
||
|---|---|---|
| .. | ||
| data | ||
| accounting_tests.cpp | ||
| alert_tests.cpp | ||
| allocator_tests.cpp | ||
| base32_tests.cpp | ||
| base58_tests.cpp | ||
| base64_tests.cpp | ||
| bignum.h | ||
| bip32_tests.cpp | ||
| bloom_tests.cpp | ||
| canonical_tests.cpp | ||
| checkblock_tests.cpp | ||
| Checkpoints_tests.cpp | ||
| compress_tests.cpp | ||
| crypto_tests.cpp | ||
| DoS_tests.cpp | ||
| getarg_tests.cpp | ||
| hash_tests.cpp | ||
| key_tests.cpp | ||
| main_tests.cpp | ||
| Makefile | ||
| miner_tests.cpp | ||
| mruset_tests.cpp | ||
| multisig_tests.cpp | ||
| netbase_tests.cpp | ||
| pmt_tests.cpp | ||
| README.md | ||
| rpc_tests.cpp | ||
| rpc_wallet_tests.cpp | ||
| script_P2SH_tests.cpp | ||
| script_tests.cpp | ||
| scriptnum_tests.cpp | ||
| serialize_tests.cpp | ||
| sighash_tests.cpp | ||
| sigopcount_tests.cpp | ||
| skiplist_tests.cpp | ||
| test_bitcoin.cpp | ||
| transaction_tests.cpp | ||
| uint256_tests.cpp | ||
| util_tests.cpp | ||
| wallet_tests.cpp | ||
Notes
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since bitcoin already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).
The build system is setup to compile an executable called "test_bitcoin" that runs all of the unit tests. The main source file is called test_bitcoin.cpp, which simply includes other files that contain the actual unit tests (outside of a couple required preprocessor directives). The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is "<source_filename>_tests.cpp" and such files should wrap their tests in a test suite called "<source_filename>_tests". For an examples of this pattern, examine uint160_tests.cpp and uint256_tests.cpp.
For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.