History

MarcoFalke b80cdfec9a Merge #16618 : [Fix] Allow connection of a noban banned peer `d117f4541d` Add test for setban (nicolas.dorier) `dc7529abf0` [Fix] Allow connection of a noban banned peer (nicolas.dorier) Pull request description: Reported by @MarcoFalke on https://github.com/bitcoin/bitcoin/pull/16248#discussion_r314026195 The bug would mean that if the peer connecting to you is banned, but whitelisted without specific permissions, it would not be able to connect to the node. The solution is just to move the same line below. ACKs for top commit: Sjors: Agree inline is more clear. utACK `d117f45` MarcoFalke: ACK `d117f4541d` Tree-SHA512: 0fed39acb1e8db67bb0bf4c4de3ad034ae776f38d55bd661f1ae0e1a4c6becaf1824ab46ed8279f2f31df3f4b29ff56461d8b167d3e9cece62cfe58b5a912811		2019-08-16 10:17:25 -04:00
..
check-doc.py	lint: Check that all wallet args are hidden	2019-04-28 12:43:50 -04:00
check-rpc-mappings.py
commit-script-check.sh	Enable ShellCheck rules	2019-07-04 19:35:25 +03:00
extended-lint-all.sh	Add Travis check for single parameter constructors not marked "explicit"	2019-06-26 16:57:14 +02:00
extended-lint-cppcheck.sh	Add Travis check for single parameter constructors not marked "explicit"	2019-06-26 16:57:14 +02:00
git-subtree-check.sh
lint-all.sh	Run all lint scripts	2019-05-16 16:42:59 +02:00
lint-assertions.sh
lint-circular-dependencies.sh	Enable ShellCheck rules	2019-07-04 19:35:25 +03:00
lint-filenames.sh
lint-format-strings.py	scripted-diff: Make translation bilingual	2019-07-24 16:33:20 +03:00
lint-format-strings.sh	Replace remaining fprintf with tfm::format manually	2019-06-13 11:46:38 -04:00
lint-include-guards.sh
lint-includes.sh
lint-locale-dependence.sh	Replace remaining fprintf with tfm::format manually	2019-06-13 11:46:38 -04:00
lint-logs.sh	Enable ShellCheck rules	2019-07-04 19:35:25 +03:00
lint-python-dead-code-whitelist	lint: Add false positive to python dead code linter	2019-08-15 08:05:14 -04:00
lint-python-dead-code.sh	lint: Add false positive to python dead code linter	2019-08-15 08:05:14 -04:00
lint-python-utf8-encoding.sh
lint-python.sh	Limit Python linting to files in the repo	2019-05-30 22:36:54 +02:00
lint-qt.sh
lint-rpc-help.sh
lint-shebang.sh
lint-shell-locale.sh
lint-shell.sh	Enable ShellCheck rules	2019-07-04 19:35:25 +03:00
lint-spelling.ignore-words.txt	Add test for setban	2019-08-16 13:40:31 +09:00
lint-spelling.sh
lint-tests.sh
lint-whitespace.sh	Replace script name with special parameter	2019-02-12 23:25:54 +02:00
README.md

README.md

This folder contains lint scripts.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

To use, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb.git (branch bitcoin-fork)
for src/univalue: https://github.com/bitcoin-core/univalue.git (branch master)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)

Usage: git-subtree-check.sh DIR (COMMIT)

COMMIT may be omitted, in which case HEAD is used.

lint-all.sh

Calls other scripts with the lint- prefix.