LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/doc
History
fanquake 0d65106dce
Merge #16383: rpcwallet: default include_watchonly to true for watchonly wallets 
72eaab073b tests: functional watch-only wallet tests (William Casarin)
72ffbdc579 doc: add release note for include_watchonly default changes (William Casarin)
003a3c73c0 rpcwallet: document include_watchonly default for watchonly wallets (William Casarin)
a50d9e6c0b rpcwallet: default include_watchonly to true for watchonly wallets (William Casarin)

Pull request description:

  Right now it's a bit annoying to deal with watchonly wallets, many rpc commands have an `include_watchonly` argument that needs to be explicitly set.

  Wallets created with `createwallet` can have a `disable_private_keys` parameter, for those wallets we already know that they are watchonly, so there's no reason to have to explicitly ask for it for every command. Instead we check this wallet flag when the `include_watchonly` parameter isn't set.

ACKs for top commit:
  achow101:
    Code review ACK 72eaab073b
  Sjors:
    ACK 72eaab073b
  promag:
    ACK 72eaab073b, code review only, didn't look closely to the test.
  kallewoof:
    ACK 72eaab073b
  fanquake:
    ACK 72eaab073b - I've looked over the changes, they make sense to me. Compiled and ran the tests etc.

Tree-SHA512: d3646b55e97f386594d7efc994f0712f3888475c6a5dc7f131ac9f8c49bf5d4677182b88f42b34152abe1ad101ecadd152b4c20e9d3c1267190db36f77ab8bd7
2019-08-16 11:55:35 +08:00
..
man Remove -mempoolreplacement to prevent needless block prop slowness. 2019-06-08 09:32:33 -04:00
release-notes Add missing contributor to release notes 2019-08-14 23:01:36 +12:00
.gitignore Ignore Doxyfile generated from Doxyfile.in template. 2017-04-07 16:28:12 +02:00
assets-attribution.md [doc] Merge doc/assets-attribution.md into contrib/debian/copyright 2015-09-18 18:14:42 +02:00
benchmarking.md [doc] Update and extend benchmarking.md 2019-08-02 13:33:13 -04:00
bips.md doc: Update bips 35, 37 and 111 status 2019-07-21 10:21:40 -04:00
bitcoin-conf.md doc: add note on precedence of options in bitcoin.conf 2019-07-25 09:57:57 +08:00
bitcoin_logo_doxygen.png Lossless image optimization 2013-12-02 10:10:22 +01:00
build-freebsd.md doc: update FreeBSD build guide for 12.0 2019-02-15 19:54:59 +08:00
build-netbsd.md doc: update NetBSD build instructions for 8.0 2018-12-13 12:05:45 +08:00
build-openbsd.md Merge #14515: doc: Update OpenBSD build guide for 6.4 2018-11-05 13:26:37 +01:00
build-osx.md doc: Fix broken link in doc/build-osx.md 2019-06-29 16:32:36 +02:00
build-unix.md Merge #16586: doc: Mention other ways to conserve memory on compilation 2019-08-14 14:12:26 +08:00
build-windows.md Remove Windows 32 bit build 2019-05-03 13:41:27 -04:00
dependencies.md doc: remove line numbers from qt package links 2019-07-24 09:17:48 +08:00
descriptors.md Mention new descriptor RPCs in descriptors.md 2019-04-06 08:17:51 -07:00
developer-notes.md doc: Fix grammar and punctuation in developer notes 2019-08-03 09:30:37 -06:00
dnsseed-policy.md Correct spelling mistakes in doc folder 2015-10-18 06:25:43 +10:00
Doxyfile.in doc: Include static members in Doxygen 2019-07-06 11:48:18 -04:00
files.md Add nice table to files.md 2018-12-11 22:24:09 +01:00
fuzzing.md Update doc and CI config 2019-07-08 20:28:58 -04:00
gitian-building.md doc: move gitian building to external repo 2017-09-25 15:45:38 +02:00
init.md init: Modify docs and add release note for 12255 2019-02-04 09:18:28 -05:00
JSON-RPC-interface.md doc: Clarify RPC versioning 2019-04-15 11:20:16 -04:00
productivity.md docs: Add productivity notes for "dummy rebases" 2019-05-15 14:12:45 -04:00
psbt.md doc: fix/improve analyzepsbt in doc/psbt.md 2019-05-19 17:31:37 +02:00
README.md docs: add reduce-memory.md 2019-07-06 10:45:04 +08:00
README_windows.txt doc: Remove version numbers from READMEs 2017-04-05 09:40:48 +02:00
reduce-memory.md docs: add reduce-memory.md 2019-07-06 10:45:04 +08:00
reduce-traffic.md doc: Mention blocksonly in reduce-traffic.md, unhide option 2019-05-13 10:44:46 -04:00
release-notes-0.18.1-16257.md [wallet] abort when attempting to fund a transaction above maxtxfee 2019-06-28 22:44:38 -04:00
release-notes-13756.md docs: release note wording 2019-06-22 02:45:40 +09:00
release-notes-14054.md [docs] release note for disabling reject messages by default 2019-03-15 09:16:12 -04:00
release-notes-14802.md rpc: faster getblockstats using BlockUndo data 2019-05-10 08:33:14 -04:00
release-notes-14954.md docs: add release note for 14954 2019-05-28 14:17:31 -04:00
release-notes-15006.md Add option to create an encrypted wallet 2019-05-13 22:49:34 -04:00
release-notes-15427.md [docs] Add release notes for PR 15427 2019-07-05 10:47:01 +01:00
release-notes-15566.md cli: replace testnet with chain and return network name as per BIP70. 2019-03-09 16:35:26 +08:00
release-notes-15620.md doc: Add release notes for 15620 2019-03-19 17:06:43 -04:00
release-notes-15637.md rpc: Rename size to vsize in mempool related calls 2019-03-24 12:01:43 +08:00
release-notes-15730.md doc: Add release notes for 15730 2019-05-02 11:39:07 +01:00
release-notes-15849.md threads: prefix log messages with thread names 2019-04-29 13:49:15 -04:00
release-notes-15993.md doc: Add release notes for 15993 2019-06-07 09:40:23 +02:00
release-notes-16060.md [docs] Add release notes for burying bip 9 soft fork deployments 2019-08-14 15:52:52 -04:00
release-notes-16383.md doc: add release note for include_watchonly default changes 2019-07-24 03:33:53 -07:00
release-notes-16394.md Allow createwallet to take empty passwords to make unencrypted wallets 2019-07-29 11:50:24 -04:00
release-notes.md doc: Add release note for the deprecated totalFee option of bumpfee 2019-07-31 12:32:55 +01:00
release-process.md doc: Remove explicit mention of version from SECURITY.md 2019-06-14 06:39:17 -04:00
REST-interface.md rpc: Expose g_is_mempool_loaded via getmempoolinfo and /rest/mempool/info.json 2019-03-22 02:31:20 -07:00
shared-libraries.md doc: correct bitcoinconsensus_version in shared-libraries 2019-04-07 21:42:32 +08:00
tor.md doc: describe onlynet option in doc/tor.md 2019-04-11 14:05:02 +02:00
translation_process.md docs: Update Transifex links 2019-03-02 17:42:33 +08:00
translation_strings_policy.md A few textual improvements 2019-02-08 09:47:50 +01:00
zmq.md ZMQ: add options to configure outbound message high water mark, aka SNDHWM 2018-10-19 07:36:13 -04:00

README.md

Bitcoin Core

Setup

Bitcoin Core is the original Bitcoin client and it builds the backbone of the network. It downloads and, by default, stores the entire history of Bitcoin transactions, which requires a few hundred gigabytes of disk space. Depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to a day or more.

To download Bitcoin Core, visit bitcoincore.org.

Running

The following are some helpful notes on how to run Bitcoin Core on your native platform.

Unix

Unpack the files into a directory and run:

  • bin/bitcoin-qt (GUI) or
  • bin/bitcoind (headless)

Windows

Unpack the files into a directory, and then run bitcoin-qt.exe.

macOS

Drag Bitcoin Core to your applications folder, and then run Bitcoin Core.

Need Help?

Building

The following are developer notes on how to build Bitcoin Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.

Development

The Bitcoin repo's root README contains relevant information on the development process and automated testing.

Resources

Miscellaneous

License

Distributed under the MIT software license. This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit. This product includes cryptographic software written by Eric Young (eay@cryptsoft.com), and UPnP software written by Thomas Bernard.