LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/src/script
History
MarcoFalke 384967f311
Merge #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool 
9cc0230cfc Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes. (practicalswift)
579497e77a tests: Explicitly ignore the return value of DecodeBase58(...) (practicalswift)
145fe95ec7 tests: Check return value of ParseParameters(...) (practicalswift)
7c5bc2a523 miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee (practicalswift)

Pull request description:

  Changes in this PR:
  * ~~Add linter to make sure the return value of `Parse[...](...)` is checked~~
  * Add `__attribute__((warn_unused_result))` to all `{Decode,Parse}[...](...)` functions returning `bool`
  * Fix violations

  Context:
  * #13712: `wallet: Fix non-determinism in ParseHDKeypath(...). Avoid using an uninitialized variable in path calculation.` would have been prevented by this

Tree-SHA512: 41a97899f2d5a26584235fa02b1ebfb4faacd81ea97e927022955a658fa7e15d07a1443b4b7635151a43259a1adf8f2f4de3c1c75d7b5f09f0d5496463a1dae6
2018-11-15 14:39:37 -05:00
..
bitcoinconsensus.cpp Drop unused GetType() from CSizeComputer 2018-09-11 00:58:05 -04:00
bitcoinconsensus.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
descriptor.cpp Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes. 2018-11-05 17:03:11 +01:00
descriptor.h Replace duplcate reference with reference to reference doc 2018-09-05 11:27:43 -07:00
interpreter.cpp Merge #13780: 0.17: Pre-branch maintenance 2018-08-08 13:55:27 +02:00
interpreter.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
ismine.cpp doxygen: Fix member comments 2018-09-26 15:42:21 -04:00
ismine.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
script.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
script.h Avoid using numeric_limits for sequence numbers and lock times 2018-11-01 12:55:39 -04:00
script_error.cpp Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
script_error.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
sigcache.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
sigcache.h Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
sign.cpp Merge #14689: Require a public key to be retrieved when signing a P2PKH input 2018-11-09 20:14:28 -08:00
sign.h Merge #14690: Throw error if CPubKey is invalid during PSBT keypath serialization 2018-11-13 13:44:09 +01:00
standard.cpp scripted-diff: Move util files to separate directory. 2018-11-04 22:46:07 -08:00
standard.h Merge #13429: Return the script type from Solver 2018-08-25 17:41:00 +02:00