LBRYCommunity/lbrycrd
1
0
Fork 0
Code Issues 29 Pull requests 1 Projects Releases 32 Packages Wiki Activity
lbrycrd/contrib
History
MarcoFalke e115a21f79
Merge #16223: devtools: Fetch and display ACKs at sign-off time in github-merge 
0e01e4522e devtools: Fetch and display ACKs at sign-off time in github-merge (Wladimir J. van der Laan)

Pull request description:

  - Fetch the ACKs only at sign-off time. This makes sure that any last-minute ACKs are included (fixes #16200)
  - Show a list of ACKs that will be included and their author before signing off, and warn if there are none

  ![1](https://user-images.githubusercontent.com/126646/59605250-ad070980-910e-11e9-9f9a-d789c7f06ebb.png)
  ![2](https://user-images.githubusercontent.com/126646/59605255-b1332700-910e-11e9-80a5-d1e244f48264.png)

  There's a slight change to the merge commit format—before it was
  ```
      ACKs for commit 88884c:
  (list of ACKs, could be empty)
  ```
  now it is
  ```
  ACKs for top commit:
        jnewbery:
          ACK 5ebc6b0eb
      ... (list of ACKs cannot be empty)
  ```
  or
  ```
  Top commit has no ACKs.
  ```
  I don't think there's a reason to have the abbreviated commit ID there, after all the full commit id is already in the beginning of the merge commit message, and at least the abbreviated one is in every single ACK message.

ACKs for commit 0e01e4:
  fanquake:
    ACK 0e01e4522e

Tree-SHA512: 8576de016137d71cfc101747e9bb6779c13e0953cf2babee7afc9972bf2bd46f6912be4982b54fa5abf4d91e98e8fdae6b4ca3eef7d6892b7a5f04a7017b6882
2019-06-24 15:09:24 -04:00
..
debian [Trivial] Update license year range to 2019 2018-12-31 04:27:59 +01:00
devtools Merge #16223: devtools: Fetch and display ACKs at sign-off time in github-merge 2019-06-24 15:09:24 -04:00
gitian-descriptors scripted-diff: gitian: Use REFERENCE_DATETIME directly. 2019-06-10 15:14:05 -04:00
gitian-keys Add Gitian key for droark 2019-03-16 16:33:39 -07:00
init init: Use systemd automatic directory creation 2019-01-05 13:21:44 +08:00
linearize build: Require python 3.5 2019-03-02 10:40:23 -05:00
macdeploy build: Drop macports support 2019-01-16 12:13:59 -08:00
qos Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes. 2018-12-02 16:14:21 +02:00
seeds Filter IPv6 by ASN 2019-04-17 17:32:05 +00:00
testgen contrib: Adjust output to current test format 2018-08-27 20:14:47 +09:00
verify-commits scripts: add key for fanquake to trusted keys list 2019-06-07 09:48:12 +02:00
verifybinaries Obsolete #!/bin/bash shebang 2018-06-20 11:12:41 +03:00
windeploy release: Update the Windows Codesigning certificate 2019-03-28 00:07:38 -04:00
zmq build: Require python 3.5 2019-03-02 10:40:23 -05:00
bitcoin-cli.bash-completion remove deprecated mentions of signrawtransaction from fundraw help 2019-02-04 10:26:46 -05:00
bitcoin-qt.pro Rename rpcconsole.ui => debugwindow.ui 2015-09-23 10:27:39 +02:00
bitcoin-tx.bash-completion bash-completion: Adapt for 0.12 and 0.13 2016-07-07 07:52:59 -04:00
bitcoind.bash-completion Fix inconsistencies and grammar in various files 2017-06-27 19:59:07 +12:00
filter-lcov.py Explicitly specify encoding when opening text files in Python code 2018-06-12 21:34:52 +02:00
gitian-build.py contrib: add curl as a required program in gitian-build.py 2019-05-28 12:51:53 -04:00
install_db4.sh contrib: use newer config.guess & config.sub in install_db4.sh 2019-05-24 15:48:34 -04:00
README.md contrib: Remove debian and rpm subfolders 2018-07-30 14:00:56 -04:00
valgrind.supp contrib: Add Valgrind suppressions file 2017-08-16 21:39:31 +02:00

README.md

Repository Tools

Developer tools

Specific tools for developers working on this repository. Contains the script github-merge.py for merging GitHub pull requests securely and signing them using GPG.

Verify-Commits

Tool to verify that every merge commit was signed by a developer using the above github-merge.py script.

Linearize

Construct a linear, no-fork, best version of the blockchain.

Qos

A Linux bash script that will set up traffic control (tc) to limit the outgoing bandwidth for connections to the Bitcoin network. This means one can have an always-on bitcoind instance running, and another local bitcoind/bitcoin-qt instance which connects to this node and receives blocks from it.

Seeds

Utility to generate the pnSeed[] array that is compiled into the client.

Build Tools and Keys

Packaging

The Debian subfolder contains the copyright file.

All other packaging related files can be found in the bitcoin-core/packaging repository.

Gitian-descriptors

Files used during the gitian build process. For more information about gitian, see the the Bitcoin Core documentation repository.

Gitian-keys

PGP keys used for signing Bitcoin Core Gitian release results.

MacDeploy

Scripts and notes for Mac builds.

Gitian-build

Script for running full Gitian builds.

Test and Verify Tools

TestGen

Utilities to generate test vectors for the data-driven Bitcoin tests.

Verify Binaries

This script attempts to download and verify the signature file SHA256SUMS.asc from bitcoin.org.