lbrycrd/test/functional
Brannon King 489edb7e0b Do not try to search only in cache, flush can discard changes
Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>
2020-02-18 17:08:33 -07:00
..
data check that a separator is found for psbt inputs, outputs, and global map 2018-12-03 10:32:58 -08:00
test_framework No longer shutdown after encrypting the wallet 2019-03-11 13:20:41 +00:00
.gitignore Rename rpc-tests directory to functional 2017-03-20 10:40:31 -04:00
combine_logs.py qa: Log as utf-8 2018-06-11 16:22:46 -04:00
combined_log_template.html Introduce combine_logs.py to combine log files from multiple bitcoinds. 2017-03-21 17:30:13 -04:00
create_cache.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
example_test.py Import CInv from correct module 2018-10-24 22:02:42 -04:00
feature_assumevalid.py Merge #13916: qa: wait_for_verack by default 2018-08-09 08:07:28 -04:00
feature_bip68_sequence.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_block.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_blocksdir.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_cltv.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_config_args.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_csv_activation.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_dbcrash.py remove leveldb, made tests pass 2020-01-15 14:39:48 -07:00
feature_dersig.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_fee_estimation.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_help.py flattening prefix trie work 2019-07-01 14:44:28 -06:00
feature_includeconf.py Ignore unknown config file options for now 2018-07-30 18:01:20 -07:00
feature_logging.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_maxuploadtarget.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_minchainwork.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_notifications.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_nulldummy.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_proxy.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
feature_pruning.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_rbf.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_reindex.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_segwit.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
feature_uacomment.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
feature_versionbits_warning.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
interface_bitcoin_cli.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
interface_http.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
interface_rest.py allow rest/block/height.json 2019-07-01 14:44:28 -06:00
interface_zmq.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mempool_accept.py Do not try to search only in cache, flush can discard changes 2020-02-18 17:08:33 -07:00
mempool_limit.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mempool_packages.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mempool_persist.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mempool_reorg.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mempool_resurrect.py Tests: Fix a comment 2018-11-28 15:35:05 -05:00
mempool_spend_coinbase.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mining_basic.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mining_getblocktemplate_longpoll.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
mining_prioritisetransaction.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_compactblocks.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_disconnect_ban.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
p2p_feefilter.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_fingerprint.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_invalid_block.py qa: Avoid race in p2p_invalid_block by waiting for the block request 2018-11-30 22:40:57 +08:00
p2p_invalid_locator.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_invalid_tx.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_leak.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_mempool.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
p2p_node_network_limited.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_segwit.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_sendheaders.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
p2p_timeouts.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
p2p_unrequested_blocks.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
README.md docs: Specify preferred Python string formatting technique 2018-07-19 12:27:42 -07:00
rpc_bind.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
rpc_blockchain.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_createmultisig.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_decodescript.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
rpc_deprecated.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_fundrawtransaction.py No longer shutdown after encrypting the wallet 2019-03-11 13:20:41 +00:00
rpc_getblockstats.py Merge #13918: rpc: Replace median fee rate with feerate percentiles in getblockstats 2018-08-13 07:18:25 -04:00
rpc_getchaintips.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_help.py qa: Add test to ensure node can generate all help texts at runtime 2018-11-28 15:35:05 -05:00
rpc_invalidateblock.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_named_arguments.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
rpc_net.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
rpc_preciousblock.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_psbt.py fix converttopsbt permitsigdata arg, add basic test 2018-12-05 17:38:57 -05:00
rpc_rawtransaction.py rpc: Avoid creating non-standard raw transactions 2018-12-07 11:36:29 -05:00
rpc_scantxoutset.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_signmessage.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_signrawtransaction.py [wallet] Ensure wallet is unlocked before signing 2018-11-28 15:35:05 -05:00
rpc_txoutproof.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
rpc_uptime.py Update copyright headers to 2018 2018-07-27 07:15:02 -04:00
rpc_users.py Merge #13867: qa: Make extended tests pass on native Windows 2018-08-11 07:01:37 -04:00
rpc_zmq.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
test_runner.py [tests] Add wallet_balance.py 2018-11-30 11:25:20 -05:00
wallet_abandonconflict.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_address_types.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_backup.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_balance.py [tests] Add wallet_balance.py 2018-11-30 11:25:20 -05:00
wallet_basic.py [tests] Add wallet_balance.py 2018-11-30 11:25:20 -05:00
wallet_bumpfee.py No longer shutdown after encrypting the wallet 2019-03-11 13:20:41 +00:00
wallet_disable.py tests: Use explicit imports 2018-08-13 14:13:39 +02:00
wallet_disableprivatekeys.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_dump.py No longer shutdown after encrypting the wallet 2019-03-11 13:20:41 +00:00
wallet_encryption.py No longer shutdown after encrypting the wallet 2019-03-11 13:20:41 +00:00
wallet_fallbackfee.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_groups.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_hd.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_import_rescan.py Merge #14441: [wallet] Backport(0.17): Restore ability to list incoming transactions by label 2018-11-10 12:45:44 +01:00
wallet_importmulti.py importmulti: Don't add internal addresses to address book 2018-12-09 22:32:45 +08:00
wallet_importprunedfunds.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_keypool.py No longer shutdown after encrypting the wallet 2019-03-11 13:20:41 +00:00
wallet_keypool_topup.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_labels.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_listreceivedby.py Fix listreceivedbyaddress not taking address as a string 2018-11-28 15:35:05 -05:00
wallet_listsinceblock.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_listtransactions.py Merge #14441: [wallet] Backport(0.17): Restore ability to list incoming transactions by label 2018-11-10 12:45:44 +01:00
wallet_multiwallet.py qa: Test .walletlock file is closed 2019-03-12 23:24:11 +00:00
wallet_resendwallettransactions.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_txn_clone.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_txn_doublespend.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00
wallet_zapwallettxes.py qa: Run all tests even if wallet is not compiled 2018-10-24 22:02:36 -04:00

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports where possible
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a bitcoind.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.