LBRYCommunity/lbryinc
1
0
Fork 0
Code Issues Pull requests 1 Packages Projects Releases Wiki Activity

[WIP] lbryio internal API calls and rewards component #1

Merged
akinwale merged 2 commits from initial-module into master 2018-07-23 15:12:18 +02:00
Conversation 2 Commits 2 Files changed 24 +15266
akinwale commented 2018-07-03 12:31:20 +02:00 (Migrated from github.com)
Copy link
No description provided.
kauffj (Migrated from github.com) reviewed 2018-07-03 12:31:20 +02:00
skhameneh (Migrated from github.com) reviewed 2018-07-03 12:31:20 +02:00
neb-b (Migrated from github.com) requested changes 2018-07-03 17:37:20 +02:00
neb-b (Migrated from github.com) left a comment
Copy link

Two comments, not sure about the window one. That might not be needed.

Two comments, not sure about the window one. That might not be needed.
src/index.js
neb-b (Migrated from github.com) commented 2018-07-03 17:37:01 +02:00
Copy link

Might as well export the redux stuff too.

Might as well export the redux stuff too.
src/lbryio.js
neb-b (Migrated from github.com) commented 2018-07-03 17:36:11 +02:00
Copy link

Do you need to check that window is an object so it doesn't break android?

Do you need to check that `window` is an object so it doesn't break android?
kauffj (Migrated from github.com) reviewed 2018-07-03 17:44:07 +02:00
kauffj (Migrated from github.com) left a comment
Copy link

Comments

Comments
src/constants/action_types.js
kauffj (Migrated from github.com) commented 2018-07-03 17:42:34 +02:00
Copy link

This should probably be AUTHENTICATION_START, AUTHENTICATION_SUCCESS, and AUTHENTICATION_FAIL. (AUTH_XXX would also be acceptable).

171ea2b97b/src/renderer/constants/action_types.js (L2)

This should probably be `AUTHENTICATION_START`, `AUTHENTICATION_SUCCESS`, and `AUTHENTICATION_FAIL`. (`AUTH_XXX` would also be acceptable). https://github.com/lbryio/lbry-app/blob/171ea2b97b6a393c880995a42cd4189cdda3e5bd/src/renderer/constants/action_types.js#L2
src/redux/actions/auth.js
kauffj (Migrated from github.com) commented 2018-07-03 17:38:48 +02:00
Copy link

Isn't this more like doAuthentication then doNewInstallation?

Isn't this more like `doAuthentication` then `doNewInstallation`?
kauffj (Migrated from github.com) commented 2018-07-03 17:44:00 +02:00
Copy link

Guessing you just haven't gotten to it, but worth porting this too 171ea2b97b/src/renderer/redux/actions/user.js (L39)

Guessing you just haven't gotten to it, but worth porting this too https://github.com/lbryio/lbry-app/blob/171ea2b97b6a393c880995a42cd4189cdda3e5bd/src/renderer/redux/actions/user.js#L39
kauffj (Migrated from github.com) reviewed 2018-07-06 23:21:04 +02:00
src/lbryio.js
kauffj (Migrated from github.com) commented 2018-07-06 23:21:04 +02:00
Copy link

@seanyesmunt @akinwale if window isn't safe to use on Android then I'd propose the convention that it's unacceptable to use it in all shared JS code and instead must be passed in as a dependency. Littering code with window && window.foo() will hurt maintainability, readability, and introduce additional sources of error.

@seanyesmunt @akinwale if `window` isn't safe to use on Android then I'd propose the convention that it's unacceptable to use it in all shared JS code and instead must be passed in as a dependency. Littering code with `window && window.foo()` will hurt maintainability, readability, and introduce additional sources of error.
kauffj (Migrated from github.com) reviewed 2018-07-06 23:21:52 +02:00
src/lbryio.js
kauffj (Migrated from github.com) commented 2018-07-06 23:21:52 +02:00
Copy link

To be clear, I'm not suggesting passing in window, specifically, but instead a generic term (such as store or whatever is appropriate) to be used in it's stead.

To be clear, I'm not suggesting passing in `window`, specifically, but instead a generic term (such as `store` or whatever is appropriate) to be used in it's stead.
akinwale (Migrated from github.com) reviewed 2018-07-18 13:02:09 +02:00
src/lbryio.js
akinwale (Migrated from github.com) commented 2018-07-18 13:02:08 +02:00
Copy link

Looks like window exists is actually already set to global React Native (https://github.com/facebook/react-native/blob/master/Libraries/Core/InitializeCore.js#L34-L36), so I can remove this.

Looks like `window` exists is actually already set to `global` React Native (https://github.com/facebook/react-native/blob/master/Libraries/Core/InitializeCore.js#L34-L36), so I can remove this.
akinwale commented 2018-07-18 13:56:55 +02:00 (Migrated from github.com)
Copy link

@kauffj @seanyesmunt Pushed a new commit which includes the rewards actions/reducers/selectors, user reducers and selectors and a subset of user actions.

@kauffj @seanyesmunt Pushed a new commit which includes the rewards actions/reducers/selectors, user reducers and selectors and a subset of user actions.
skhameneh commented 2018-07-18 15:45:16 +02:00 (Migrated from github.com)
Copy link

Looks good to me, I'll wait for @seanyesmunt's input on this

Looks good to me, I'll wait for @seanyesmunt's input on this
neb-b (Migrated from github.com) approved these changes 2018-07-19 15:51:54 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
kauffj
skhameneh
neb-b
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#1
No description provided.
Delete branch "initial-module"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?