update lbry-redux #11

2018-10-25T19:01:52+02:00

neb-b commented

2018-10-25 19:01:52 +02:00

(Migrated from github.com)

No description provided.

neb-b (Migrated from github.com) reviewed 2018-10-25 19:13:11 +02:00

					
				@ -1429,1 +1459,4 @@

				});

				Object.defineProperty(exports, 'creditsToString', {

				  enumerable: true,

				  get: function get() {

neb-b (Migrated from github.com) commented

2018-10-25 19:13:11 +02:00

@skhameneh

I've noticed that after I use yarn link. Webpack starts to bring in functions that aren't used in this module. It was after I pointed lbryinc and lbry-desktop to my local instance of lbry-redux. Any idea how to prevent this?

@skhameneh I've noticed that after I use `yarn link`. Webpack starts to bring in functions that aren't used in this module. It was after I pointed `lbryinc` and `lbry-desktop` to my local instance of `lbry-redux`. Any idea how to prevent this?

skhameneh (Migrated from github.com) reviewed 2018-10-26 18:42:33 +02:00

dist/bundle.js

					
				@ -1429,1 +1459,4 @@

				});

				Object.defineProperty(exports, 'creditsToString', {

				  enumerable: true,

				  get: function get() {

skhameneh (Migrated from github.com) commented

2018-10-26 18:42:33 +02:00

It'll be built against what's linked and it's subjective to your dev environment.
The proper fix is to remove artifacts from the repo.

It'll be built against what's linked and it's subjective to your dev environment. The proper fix is to remove artifacts from the repo.

skhameneh (Migrated from github.com) approved these changes 2018-10-26 18:42:47 +02:00

Sign in to join this conversation.

No reviewers

skhameneh

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#11