LBRYCommunity/lbryinc

fix: prevent multiple user/me calls for new users #23

Merged

neb-b merged 1 commit from user-me into master

2019-02-04 05:24:22 +01:00

neb-b commented

2019-01-30 18:32:11 +01:00

(Migrated from github.com)

This should work the exact same way as before, but with one less user/me call for returning users. If we already have the user, we can just return that instead of fetching it again.

This should work the exact same way as before, but with one less `user/me` call for returning users. If we already have the user, we can just return that instead of fetching it again.

skhameneh (Migrated from github.com) reviewed 2019-02-01 21:51:00 +01:00

skhameneh (Migrated from github.com) left a comment

Not explicitly approving, but you can merge, although I'm not fond of the new logic.

Not explicitly approving, but you _can_ merge, although I'm not fond of the new logic.

skhameneh (Migrated from github.com) commented

2019-02-01 21:50:26 +01:00

Can't you just pass user or false?
User should never be false, if it's false then you know it failed.

Can't you just pass user or false? User should never be false, if it's false then you know it failed.

neb-b (Migrated from github.com) reviewed 2019-02-01 21:53:15 +01:00

neb-b (Migrated from github.com) commented

2019-02-01 21:53:15 +01:00

Ah that's a good point and much cleaner. I will update.

Ah that's a good point and much cleaner. I will update.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#23

No description provided.