Add callbacks to `getSync` #67

Merged

neb-b merged 3 commits from sync-cb into master

2019-10-15 16:32:29 +02:00

neb-b commented

(Migrated from github.com)

I also removed the default account stuff from doGetSync since we don't need that more.

I also removed the default account stuff from `doGetSync` since we don't need that more.

akinwale (Migrated from github.com) requested changes 2019-10-15 06:25:43 +02:00

akinwale (Migrated from github.com) left a comment

Just one small issue. Everything else looks good.

akinwale (Migrated from github.com) commented

This should probably be in an else block unless we want the callback called twice in cases where the first condition is true.

This should probably be in an `else` block unless we want the callback called twice in cases where the first condition is true.

neb-b (Migrated from github.com) reviewed 2019-10-15 16:31:11 +02:00

neb-b (Migrated from github.com) commented

Good catch.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#67

No description provided.

Rows
Columns

Add callbacks to getSync #67