add logic for reward codes #7

Merged

neb-b merged 1 commit from reward-codes into master

2018-10-02 02:47:58 +02:00

neb-b commented

2018-09-26 02:05:22 +02:00

(Migrated from github.com)

So we can implement https://github.com/lbryio/lbry-desktop/pull/1935

akinwale (Migrated from github.com) approved these changes 2018-09-29 16:35:49 +02:00

akinwale (Migrated from github.com) left a comment

Looks good to merge.

Just a minor note which is more of a design choice, since there are just two additional parameters to pass to the claim reward endpoint, you could probably have the parameters as optional method arguments which makes it easier to know what to pass at first glance.

Looks good to merge. Just a minor note which is more of a design choice, since there are just two additional parameters to pass to the claim reward endpoint, you could probably have the parameters as optional method arguments which makes it easier to know what to pass at first glance.

neb-b commented

2018-10-01 21:17:57 +02:00

(Migrated from github.com)

@akinwale I started doing that but decided it might be better to just pass all params in. It will be easier to implement new rewards if they require additional params.

neb-b commented

2018-10-02 02:37:49 +02:00

(Migrated from github.com)

I added the params to doClaimRewardType options, instead of adding an additional method param.

I added the params to `doClaimRewardType` options, instead of adding an additional method param.

No reviewers

akinwale

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#7

No description provided.