LBRYCommunity/lbryinc
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

add values for existingUser/resendingVerificationEmail #73

Merged
neb-b merged 2 commits from existing-user into master 2019-11-06 01:24:06 +01:00
Conversation 0 Commits 2 Files changed 10 +191 -40
neb-b commented 2019-10-28 18:23:36 +01:00 (Migrated from github.com)
Copy link

I also added a temporary value for tracking bad passwords. This will be changed once we have a bad password error code.

I also added a temporary value for tracking bad passwords. This will be changed once we have a bad password error code.
akinwale (Migrated from github.com) approved these changes 2019-11-05 20:08:38 +01:00
akinwale (Migrated from github.com) left a comment
Copy link

Apart from the sync_apply error handling, this looks good.

Apart from the `sync_apply` error handling, this looks good.
src/redux/actions/sync.js
@ -145,0 +148,4 @@
if (password !== '') {
dispatch({ type: ACTIONS.SYNC_APPLY_BAD_PASSWORD });
}
akinwale (Migrated from github.com) commented 2019-11-05 20:08:12 +01:00
Copy link

This seems quite ugly. It's still quite possible, although rare for sync_apply to fail for other reasons. I guess we could just assume every failure is a bad password failure so that the user can try again.

This seems quite ugly. It's still quite possible, although rare for `sync_apply` to fail for other reasons. I guess we could just assume every failure is a bad password failure so that the user can try again.
kauffj (Migrated from github.com) reviewed 2019-11-05 21:41:37 +01:00
src/redux/actions/sync.js
@ -145,0 +148,4 @@
if (password !== '') {
dispatch({ type: ACTIONS.SYNC_APPLY_BAD_PASSWORD });
}
kauffj (Migrated from github.com) commented 2019-11-05 21:41:37 +01:00
Copy link

https://github.com/lbryio/lbry-sdk/issues/2175

https://github.com/lbryio/lbry-sdk/issues/2175
neb-b (Migrated from github.com) reviewed 2019-11-06 01:24:01 +01:00
src/redux/actions/sync.js
@ -145,0 +148,4 @@
if (password !== '') {
dispatch({ type: ACTIONS.SYNC_APPLY_BAD_PASSWORD });
}
neb-b (Migrated from github.com) commented 2019-11-06 01:24:01 +01:00
Copy link

Yeah I agree. I intend to change this once https://github.com/lbryio/lbry-sdk/issues/2175 is resolved.

Yeah I agree. I intend to change this once https://github.com/lbryio/lbry-sdk/issues/2175 is resolved.
Sign in to join this conversation.
Reviewers
No reviewers
akinwale
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

Good for newcomers

  
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

Extra attention is needed

  
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
priority: blocker
priority: high
priority: low
priority: medium
resilience
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#73
No description provided.
Delete branch "existing-user"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?