new referrals #79

Merged

jessopb merged 4 commits from new_referrals into master

2020-01-14 20:47:43 +01:00

jessopb commented

2020-01-08 22:58:42 +01:00

(Migrated from github.com)

provides referral code
setting referrers
claim referee reward
fixes accessToken state

provides referral code setting referrers claim referee reward fixes accessToken state

neb-b (Migrated from github.com) reviewed 2020-01-08 22:58:42 +01:00

akinwale (Migrated from github.com) reviewed 2020-01-10 23:35:23 +01:00

akinwale (Migrated from github.com) left a comment

Apart from one concern, everything else looks good.

src/redux/actions/user.js

akinwale (Migrated from github.com) commented

2020-01-10 23:34:33 +01:00

With this, do we have to explicitly call /user/me after authentication in order to retrieve the user? This seems like an extra step that I'd like to avoid. Why can't we obtain both the user and the accessToken?

With this, do we have to explicitly call `/user/me` after authentication in order to retrieve the user? This seems like an extra step that I'd like to avoid. Why can't we obtain both the user and the accessToken?

jessopb (Migrated from github.com) reviewed 2020-01-11 01:26:24 +01:00

src/redux/actions/user.js

jessopb (Migrated from github.com) commented

2020-01-11 01:26:24 +01:00

There was a bug where "user" in the reducer was being populated with an accessToken and then overwritten with the "user" object. Here I am, I think, just making it work as the state intends.
We can run the question of whether authenticate should also return the user by @tiger5226 @kauffj @seanyesmunt etc.

There was a bug where "user" in the reducer was being populated with an accessToken and then overwritten with the "user" object. Here I am, I think, just making it work as the state intends. We can run the question of whether authenticate should also return the user by @tiger5226 @kauffj @seanyesmunt etc.