#ISSUE-2043 Add logic lost in code refactor for silent fail on rewards #9

Merged

jimmiehansson merged 2 commits from master into master

2018-10-18 19:17:01 +02:00

jimmiehansson commented

2018-10-18 10:37:56 +02:00

(Migrated from github.com)

This is a PR proposal to add the logic again for silent fail as per issue https://github.com/lbryio/lbry-desktop/issues/2043

neb-b commented

2018-10-18 18:46:15 +02:00

(Migrated from github.com)

Thanks for the PR @jimmiehansson! Can we send you LBC as appreciation?

Thanks for the PR @jimmiehansson! Can we send you [LBC as appreciation](https://lbry.io/faq/appreciation)?

neb-b commented

2018-10-18 18:46:47 +02:00

(Migrated from github.com)

@skhameneh I just ran yarn build on this branch and it seems to have taken all of the walletEncrypt stuff out. Any ideas why?

@skhameneh I just ran `yarn build` on this branch and it seems to have taken all of the walletEncrypt stuff out. Any ideas why?

neb-b commented

2018-10-18 19:16:57 +02:00

(Migrated from github.com)

I guess it doesn't matter since lbryinc doesn't use that. I'm gonna merge this.

I guess it doesn't matter since `lbryinc` doesn't use that. I'm gonna merge this.

jimmiehansson commented

2018-10-18 19:41:21 +02:00

(Migrated from github.com)

@seanyesmunt Sure thing, i'll be glad to give a hand when needed, this was very simple though.
I'd be glad to have this count for the Hacktober event if possible, any issue of priority on a bigger scale?

@seanyesmunt Sure thing, i'll be glad to give a hand when needed, this was very simple though. I'd be glad to have this count for the Hacktober event if possible, any issue of priority on a bigger scale?

neb-b commented

2018-10-18 21:27:12 +02:00

(Migrated from github.com)

@jimmiehansson Not really anything specific. I would check out anything in the desktop app with the hacktoberfest label https://github.com/lbryio/lbry-desktop/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest

tzarebczan commented

2018-10-30 00:43:21 +01:00

(Migrated from github.com)

@jimmiehansson please reach out to us at hello@lbry.io so we can send you some LBC as appreciation and get you a t-shirt for Hacktoberfest :)

@jimmiehansson please reach out to us at hello@lbry.io so we can [send you some LBC as appreciation](https://lbry.io/faq/appreciation) and get you a t-shirt for Hacktoberfest :)

❤️ 1 🎉 1

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryinc#9

No description provided.