LBRYCommunity/lbryschema.go
1
0
Fork 0
Code Issues Pull requests 1 Packages Projects Releases Wiki Activity

Added migration method. #3

Merged
tiger5226 merged 3 commits from add_migration into master 2018-11-09 23:15:53 +01:00
Conversation 1 Commits 3 Files changed 5 +555 -11
tiger5226 commented 2018-11-09 18:11:18 +01:00 (Migrated from github.com)
Copy link
No description provided.
jackrobison (Migrated from github.com) reviewed 2018-11-09 18:11:18 +01:00
lyoshenka (Migrated from github.com) reviewed 2018-11-09 18:11:18 +01:00
jackrobison (Migrated from github.com) requested changes 2018-11-09 18:23:54 +01:00
jackrobison (Migrated from github.com) left a comment
Copy link

Please add some tests for the json migration (success and failure cases). Otherwise LGTM

Please add some tests for the json migration (success and failure cases). Otherwise LGTM
claim/claim.go
@ -109,7 +111,46 @@ func DecodeClaimJSON(claimJSON string, blockchainName string) (*ClaimHelper, err
if err != nil {
return nil, err
jackrobison (Migrated from github.com) commented 2018-11-09 18:22:52 +01:00
Copy link

DRY - This through line 122 can just call DecodeClaimBytes

DRY - This through line 122 can just call `DecodeClaimBytes`
lyoshenka commented 2018-11-09 19:35:52 +01:00 (Migrated from github.com)
Copy link

This is somewhat outside the scope of this PR, but could you please import the protobuf code from https://github.com/lbryio/types/tree/master/go and delete the duplicated proto files here?

This is somewhat outside the scope of this PR, but could you please import the protobuf code from https://github.com/lbryio/types/tree/master/go and delete the duplicated proto files here?
Sign in to join this conversation.
Reviewers
No reviewers
jackrobison
lyoshenka
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryschema.go#3
No description provided.
Delete branch "add_migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?