LBRYCommunity/lbryschema.go
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

Update Migration for Proto3 #6

New issue
Closed
opened 2019-03-21 01:56:06 +01:00 by tiger5226 · 4 comments
tiger5226 commented 2019-03-21 01:56:06 +01:00 (Migrated from github.com)
Copy link

Once the proto 3 is ready this needs to be updated.

Once the proto 3 is ready this needs to be updated.
tiger5226 commented 2019-03-31 01:57:19 +01:00 (Migrated from github.com)
Copy link

This is not a duplicate. This library's migrations are used by chainquery. In order for chainquery to support the new proto3 changes. This library need to be updated to leverage the latest types branch.

This is not a duplicate. This library's migrations are used by chainquery. In order for chainquery to support the new proto3 changes. This library need to be updated to leverage the latest types branch.
tiger5226 commented 2019-03-31 03:05:33 +02:00 (Migrated from github.com)
Copy link

I also spoke with @jackrobison and he said he has no dependencies that upgrading this would break. I started this work, yesterday but there were inconsistencies that I brought up in slack at which point I found out that there is another PR with changes to the schema. Since the schema dictates the changes required for Chainquery I need that to coalesce first. Also it isn't too smart to have nested dependencies leveraging a PR branch.

I also spoke with @jackrobison and he said he has no dependencies that upgrading this would break. I started this work, yesterday but there were inconsistencies that I brought up in slack at which point I found out that there is another PR with changes to the schema. Since the schema dictates the changes required for Chainquery I need that to coalesce first. Also it isn't too smart to have nested dependencies leveraging a PR branch.
tiger5226 commented 2019-04-01 05:13:50 +02:00 (Migrated from github.com)
Copy link

A quick update. I got pretty far with the migrations. After speaking with @tzarebczan and @eukreign, @tzarebczan confirmed @lyoshenka was ok with the PR, and @eukreign said it could be merged. The library files were not generated from all the proto file changes, so I did build it for the PR, but did not merge it. Right now I am work off of the PR branch under the assumption it will not be changing significantly.

A quick update. I got pretty far with the migrations. After speaking with @tzarebczan and @eukreign, @tzarebczan confirmed @lyoshenka was ok with the PR, and @eukreign said it could be merged. The library files were not generated from all the proto file changes, so I did build it for the PR, but did not merge it. Right now I am work off of the PR branch under the assumption it will not be changing significantly.
tiger5226 commented 2019-05-04 06:18:31 +02:00 (Migrated from github.com)
Copy link

Completed.

Completed.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
gomod
proto3
remove_migratedfrom
No results found.
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lbryschema.go#6
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?