LBRYCommunity/lighthouse.js

Never return URLs in suggested search results #105

New issue

Closed

opened 2018-08-20 18:10:01 +02:00 by kauffj · 3 comments

kauffj commented

2018-08-20 18:10:01 +02:00

(Migrated from github.com)

Sometimes the search auto suggest can suggest that someone search for an entire URL. This results in a confusing user experience. The search suggestion results should never contain anything beginning with http(s):// or lbry://.

Sometimes the search auto suggest can suggest that someone search for an entire URL. This results in a confusing user experience. The search suggestion results should never contain anything beginning with `http(s)://` or `lbry://`.

tzarebczan commented

2018-08-20 18:37:47 +02:00

(Migrated from github.com)

I believe this was coming back from one of the match URL titles (not sure exactly from where though)

This is the query: https://lighthouse.lbry.io/autocomplete?s=crypto

The result:
["@cryptocollectibles","cryptocurrencysandbtc","Bitcoin is not a bubble and will surpass the US $3,000 ","cryptogames","spee.ch","cryptogames2","cryptodevpic","Image published from spee.ch","https://spee.ch"]

Probably related to https://github.com/lbryio/lighthouse/issues/55

I believe this was coming back from one of the match URL titles (not sure exactly from where though) This is the query: https://lighthouse.lbry.io/autocomplete?s=crypto The result: `["@cryptocollectibles","cryptocurrencysandbtc","Bitcoin is not a bubble and will surpass the US $3,000 ","cryptogames","spee.ch","cryptogames2","cryptodevpic","Image published from spee.ch","https://spee.ch"]` Probably related to https://github.com/lbryio/lighthouse/issues/55

tiger5226 commented

2018-08-21 01:30:49 +02:00

(Migrated from github.com)

The results generally are from #55 , but there is currently nothing preventing the start of a url from being returned. So we would need to add this filter.

The results generally are from #55 , but there is currently nothing preventing the start of a url from being returned. So we would need to add this filter.

alyssaoc commented

2018-09-14 16:23:50 +02:00

(Migrated from github.com)

closing for #55, this will be resolved

closing for #55, this will be resolved

Sign in to join this conversation.

No labels

area: discovery

area: X-device Sync

Fix till next release

good first issue

needs: exploration

needs: grooming

needs: priority

needs: tech design

priority: blocker

priority: medium

type: discussion

type: improvement

type: new feature

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#105

No description provided.