Add param for "no nsfw results" on search api #110
Labels
No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lighthouse.js#110
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
For related content, we don't want nsfw results if the user is hiding nsfw content. Currently we just strip out nsfw results app side but this results in some videos with only a few related pieces of content.
It would be nice if there was a new param which makes it so no nsfw results are returned.
@tiger5226 Why did this go back to triage?
I have no reason. I don't recall. Maybe I selected the wrong dropdown when removing my assignment. Cool with groomed.
The PR for this is complete. However, our documentation needs to be updated. @filipnyquist could you update the docs or add to the readme how this should be done? When we change the API, it would be nice if we keep the docs up to date.
https://github.com/lbryio/lighthouse/blob/master/server/routes/lighthouse.js contains the API documentation as in-line swagger doc. When that has been updated you can generate the new API docs with
npm run gendocs
which will handle everything for the documentation.If you want I can get a PR which updates the documentation after we merge the other PR @tiger5226
yeah, I tested it, and it works, so we can merge it. We need to get some auto deployment going too.
I can take a look on auto-deploying after next week, it´s an exam week so I'm quite full until after it
The initial PR and a docs update PR has been merged!
This is now live in production!