Add param for "no nsfw results" on search api #110

Closed
opened 2018-08-27 21:00:08 +02:00 by neb-b · 9 comments
neb-b commented 2018-08-27 21:00:08 +02:00 (Migrated from github.com)

For related content, we don't want nsfw results if the user is hiding nsfw content. Currently we just strip out nsfw results app side but this results in some videos with only a few related pieces of content.

It would be nice if there was a new param which makes it so no nsfw results are returned.

For related content, we don't want nsfw results if the user is hiding nsfw content. Currently we just strip out nsfw results app side but this results in some videos with only a few related pieces of content. It would be nice if there was a new param which makes it so no nsfw results are returned.
alyssaoc commented 2018-10-17 15:35:43 +02:00 (Migrated from github.com)

@tiger5226 Why did this go back to triage?

@tiger5226 Why did this go back to triage?
tiger5226 commented 2018-10-18 02:46:54 +02:00 (Migrated from github.com)

I have no reason. I don't recall. Maybe I selected the wrong dropdown when removing my assignment. Cool with groomed.

I have no reason. I don't recall. Maybe I selected the wrong dropdown when removing my assignment. Cool with groomed.
tiger5226 commented 2018-10-21 22:05:59 +02:00 (Migrated from github.com)

The PR for this is complete. However, our documentation needs to be updated. @filipnyquist could you update the docs or add to the readme how this should be done? When we change the API, it would be nice if we keep the docs up to date.

The PR for this is complete. However, our documentation needs to be updated. @filipnyquist could you update the docs or add to the readme how this should be done? When we change the API, it would be nice if we keep the docs up to date.
filipnyquist commented 2018-10-21 22:17:08 +02:00 (Migrated from github.com)

https://github.com/lbryio/lighthouse/blob/master/server/routes/lighthouse.js contains the API documentation as in-line swagger doc. When that has been updated you can generate the new API docs with npm run gendocs which will handle everything for the documentation.

https://github.com/lbryio/lighthouse/blob/master/server/routes/lighthouse.js contains the API documentation as in-line swagger doc. When that has been updated you can generate the new API docs with `npm run gendocs` which will handle everything for the documentation.
filipnyquist commented 2018-10-21 22:17:53 +02:00 (Migrated from github.com)

If you want I can get a PR which updates the documentation after we merge the other PR @tiger5226

If you want I can get a PR which updates the documentation after we merge the other PR @tiger5226
tiger5226 commented 2018-10-21 22:23:13 +02:00 (Migrated from github.com)

yeah, I tested it, and it works, so we can merge it. We need to get some auto deployment going too.

yeah, I tested it, and it works, so we can merge it. We need to get some auto deployment going too.
filipnyquist commented 2018-10-21 22:34:07 +02:00 (Migrated from github.com)

I can take a look on auto-deploying after next week, it´s an exam week so I'm quite full until after it

I can take a look on auto-deploying after next week, it´s an exam week so I'm quite full until after it
filipnyquist commented 2018-10-21 22:43:15 +02:00 (Migrated from github.com)

The initial PR and a docs update PR has been merged!

The initial PR and a docs update PR has been merged!
filipnyquist commented 2018-10-21 22:47:19 +02:00 (Migrated from github.com)

This is now live in production!

This is now live in production!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#110
No description provided.