LBRYCommunity/lighthouse.js
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bad request returned on certain searches #112

New issue
Closed
opened 2018-09-10 21:29:34 +02:00 by tzarebczan · 3 comments
tzarebczan commented 2018-09-10 21:29:34 +02:00 (Migrated from github.com)
Copy link

Examples:
https://lighthouse.lbry.io/search?s=Mar%20GamingYT%20%20%20Robux%20Simulator%20/%20REBIRTH!&size=20&from=0

https://lighthouse.lbry.io/search?s=Mar%20GamingYT%20%20%20Baldi%20Obby!%20/%20I%20got%20lost,%20but%20won!&size=20&from=0

Might be related to some special characters?

Examples: https://lighthouse.lbry.io/search?s=Mar%20GamingYT%20%20%20Robux%20Simulator%20/%20REBIRTH!&size=20&from=0 https://lighthouse.lbry.io/search?s=Mar%20GamingYT%20%20%20Baldi%20Obby!%20/%20I%20got%20lost,%20but%20won!&size=20&from=0 Might be related to some special characters?
tzarebczan commented 2018-09-10 21:30:45 +02:00 (Migrated from github.com)
Copy link

Another:
https://lighthouse.lbry.io/search?s=Playing%20Robloxian%20Life%20%20w%20god39lol/%20Mar%20GamingYT&size=20&from=0

Another: https://lighthouse.lbry.io/search?s=Playing%20Robloxian%20Life%20%20w%20god39lol/%20Mar%20GamingYT&size=20&from=0
tiger5226 commented 2018-09-11 12:56:16 +02:00 (Migrated from github.com)
Copy link

The problem is the url is not properly encoded. Forward slash when url encoded should be %2F. I think this is the right response when the api receive a malformed url.

https://lighthouse.lbry.io/search?s=Mar%20GamingYT%20%20%20RobuxSimulator%20%2F%20REBIRTH

The above is an example where it should work though and does not. The forward slash seems to cause problems somehow.

The problem is the url is not properly encoded. Forward slash when url encoded should be `%2F`. I think this is the right response when the api receive a malformed url. https://lighthouse.lbry.io/search?s=Mar%20GamingYT%20%20%20RobuxSimulator%20%2F%20REBIRTH The above is an example where it should work though and does not. The forward slash seems to cause problems somehow.
tiger5226 commented 2018-09-16 04:15:54 +02:00 (Migrated from github.com)
Copy link

So I found some more documentation on the escaped characters. Some pages had different characters to escape. I found the official documentation on escaped characters. I noted it in the codebase for reference.

https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#_reserved_characters

Solved with https://github.com/lbryio/lighthouse/pull/115

So I found some more documentation on the escaped characters. Some pages had different characters to escape. I found the official documentation on escaped characters. I noted it in the codebase for reference. https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#_reserved_characters Solved with https://github.com/lbryio/lighthouse/pull/115
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
timestamp-weight
chainquery-db-connection
strip_prefex
No results found.
Labels
Clear labels   
area: app c

Work is part of App C

  
area: app d

Work is part of App D

  
area: devops

   
area: discovery

   
area: docs

   
area: proposal

Work is part of a proposal

  
area: X-device Sync

Cross Device experience

  
Chainquery

This feature or fix will be possible with chainquery.

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
Fix till next release

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
Invalid

   
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Parked

on hold for a dependency or to be planned

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#112
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?