Search result affected by a number at end of title #119
Labels
No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lighthouse.js#119
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This query for
AdmiralBulldog Bristleback Aghanim's [YOU CAN'T RUN!] Dota 2
https://lighthouse.lbry.io/search?s=AdmiralBulldog%20Bristleback%20Aghanim%27s%20%5BYOU%20CAN%27T%20RUN!%5D%20Dota%202&size=20&from=0 - brings in high effective amount claims like one, four, six at the top fo the listRemoving the 2 at the end
AdmiralBulldog Bristleback Aghanim's [YOU CAN'T RUN!] Dota
:https://lighthouse.lbry.io/search?s=AdmiralBulldog%20Bristleback%20Aghanim%27s%20%5BYOU%20CAN%27T%20RUN!%5D%20Dota%20&size=20&from=0 - brings better results (lbry://three is up there because of
you
most likely - probably need to blacklist that word.Not sure what other instances of numbers would affect query results but it may be worth digging into.
we can blacklist numbers via a cast check. @nikooo777 is that performant in js or is there something else you would recommend?
why is the number affecting the results? aren't sequences of less than 3 chars ignored?
ahhh thats a good point niko! I will have to check the code to see if any part of the query is not being washed properly.
It seems that the after the query is washed, the result is "admiralbulldog bristleback aghanim'[you can'run!] dota". It is removing spaces that shouldn't be removed, for example it should be "you can't run". This is because of the regex.
Secondly, because of this, sometimes a trailing whitespace remains (when "2" is removed), this causes one of the queries to return all results (query_string with * wildcard). Because of the effective_amount score, top claims will appear first.
I will propose a PR to solve this issue.
Boom! nice investigation!
https://github.com/lbryio/lighthouse/pull/125 did not fix this issue. Removing the 2 at the end still gives better results (without the top claims).
@tzarebczan I checked the server, and there was an issue with the update shell script. It was in dev but not production. production should be up to date again.
closing, reopen when tom comes back from Japan