Content and channel filters

marcdeb1 commented

2018-10-22 12:34:51 +02:00

(Migrated from github.com)

This pull request is adding three more filters to the search, as talked about in issues #111 and #109.

Filter claimType can be used to search only for files or channels. Its value can be 'channel' or 'file'.
contentType allows filter by MIME type, according to the contentType field in the claim. For example, query 'contentType=image/png' will return only PNG images.
mediaType is a more general filter for content. It can have 6 values : video, image, text, application, audio or cad. The first 5 types correspond to the MIME type, 'cad' maps to the 3D model types.

Please share your suggestions and comments if there are any issues.

This pull request is adding three more filters to the search, as talked about in issues #111 and #109. - Filter claimType can be used to search only for files or channels. Its value can be 'channel' or 'file'. - contentType allows filter by MIME type, according to the contentType field in the claim. For example, query 'contentType=image/png' will return only PNG images. - mediaType is a more general filter for content. It can have 6 values : video, image, text, application, audio or cad. The first 5 types correspond to the MIME type, 'cad' maps to the 3D model types. Please share your suggestions and comments if there are any issues.

tiger5226 commented

2018-10-23 01:13:21 +02:00

(Migrated from github.com)

I am hesitant to just keep adding parameters for search. Is there a better way to do this? What do you recommend? Also you can reach me on slack too during the day as well. I know we want to prevent having to do this. Maybe multiple apis?

marcdeb1 commented

2018-10-23 15:30:32 +02:00

(Migrated from github.com)

In my opinion it is okay to add parameters it is then useful in the final app, as described in the issues mentioned. Are you on Discord ? What do you mean by multiple apis ? Different endpoints ?

tiger5226 commented

2018-10-25 01:08:33 +02:00

(Migrated from github.com)

yeah different endpoints. I am ok with it. I just wanted to validate the change is all. I am on discord @Beamer, and on slack with the same name if you join our tech-guest channel.

tiger5226 commented

2018-11-01 02:05:18 +01:00

(Migrated from github.com)

@marcdeb1 what IDE are you using? Looks like linting is not turned on yet per the codacy report above. I fixed the other PR and happy to fix this one too, but if you could also turn this on that would be cool. Let me know. We use JetBrains, but if you are using something else may have to do some googling.

marcdeb1 commented

2018-11-06 02:12:45 +01:00

(Migrated from github.com)

Fixed, I will push something clean next time !

tiger5226 commented

2018-11-06 03:12:31 +01:00

(Migrated from github.com)

Thanks! looks good! You forgot to run the generate script for documentation. That updates the docs.
https://github.com/lbryio/lighthouse/issues/110#issuecomment-431700443

Thanks! looks good! You forgot to run the generate script for documentation. That updates the docs. https://github.com/lbryio/lighthouse/issues/110#issuecomment-431700443

marcdeb1 commented

2018-11-06 15:14:14 +01:00

(Migrated from github.com)

Noted, I didn't know how to do this.

tiger5226 commented

2018-11-08 16:13:51 +01:00

(Migrated from github.com)

Thanks! Can you squash and rebase please https://github.com/lbryio/lbry/wiki/Branching-and-Merging

marcdeb1 commented

2018-12-02 11:09:39 +01:00

(Migrated from github.com)

A list of media types can now be given as input. Examples of queries :

mediaType=image,cad will return all images and CAD claims.
contentType=image/gif,video/mp4 will filter only GIFs and MP4 videos.

A list of media types can now be given as input. Examples of queries : - mediaType=image,cad will return all images and CAD claims. - contentType=image/gif,video/mp4 will filter only GIFs and MP4 videos.

tiger5226 commented

2018-12-04 01:20:26 +01:00

(Migrated from github.com)

@tzarebczan I am going to put this branch on dev for QA. Let me know if there is a different branch we should put there 1st. I wanted to get these PRs ready to be merged.

tzarebczan commented

2018-12-04 16:10:29 +01:00

(Migrated from github.com)

@tiger5226 that works for me, let's get it tested soon.

tzarebczan commented

2019-01-21 16:36:03 +01:00

(Migrated from github.com)

@nikooo777 / @tiger5226 do we have a test server to deploy this on?

nikooo777 commented

2019-01-25 13:10:09 +01:00

(Migrated from github.com)

we have a dev server for lighthouse but until issue #142 is fixed we can't turn it back on