Search adaptions and corrections. (Working Search/Autocomplete) #13

Merged
MatWaller merged 4 commits from master into master 2017-09-20 08:06:07 +02:00
MatWaller commented 2017-09-20 05:13:30 +02:00 (Migrated from github.com)

Improvements to search relevancy and separation of search/autocomplete feature.

-- Removed getSuggestion
-- Added getResults
-- Added getAutoComplete
-- Added Pagination via size and from parameters.
-- Added cleansing functionality for autocomplete as so it does not return undefined or duplicate values.

Restructured to search query to bool query that searches on a claims name, title, author and keywords in description -- it's a disaster now shows in a search for disaster autocomplete also returned correctly for the same example.

For clarity i think it is best to keep the API doing as it is requested (search end point returning search results not suggestions) -- suggestions should be returned separately ideally.

Improvements to search relevancy and separation of search/autocomplete feature. -- Removed `getSuggestion` -- Added `getResults` -- Added `getAutoComplete` -- Added Pagination via `size` and `from` parameters. -- Added cleansing functionality for autocomplete as so it does not return undefined or duplicate values. Restructured to search query to bool query that searches on a claims name, title, author and keywords in description -- `it's a disaster` now shows in a search for `disaster` autocomplete also returned correctly for the same example. For clarity i think it is best to keep the API doing as it is requested (search end point returning search results not suggestions) -- suggestions should be returned separately ideally.
filipnyquist commented 2017-09-20 08:05:55 +02:00 (Migrated from github.com)

Great work, helping me out with elasticsearch!

Great work, helping me out with elasticsearch!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#13
No description provided.