Add weight based on channel effective amount #139

New issue

Closed

opened 2019-01-09 19:22:31 +01:00 by tzarebczan · 4 comments

tzarebczan commented

2019-01-09 19:22:31 +01:00

(Migrated from github.com)

Currently, we add weight to claims based on their claim effective amounts - we should do something similar for channel effective amounts. This would ensure that channels with larger bids rank higher. I may have a large bid on my channel, but only smaller bids on each of my publishes. Think this would help in the case of searching for "Jordan B Peterson" - right now none of his channel's videos show up. The other solution to that is to allow a channel search, but that would bring up his channel, and not claims.

tiger5226 commented

2019-01-10 02:12:15 +01:00

(Migrated from github.com)

This is for all claims. Identity and Stream claims. The impact for the weight has been lowered significantly. I suspect that is the issue here.

tzarebczan commented

2019-01-10 02:14:51 +01:00

(Migrated from github.com)

fa18e29a8a/server/controllers/lighthouse.js (L63) shows an effective amount..it's either the claim or the certificate one...how could it be both?

https://github.com/lbryio/lighthouse/blob/fa18e29a8a94c20c1cd9b792aff498cbbb54d7aa/server/controllers/lighthouse.js#L63 shows an effective amount..it's either the claim or the certificate one...how could it be both?

tiger5226 commented

2019-01-10 05:04:58 +01:00

(Migrated from github.com)

certificate_amount is the channel claim's effective_amount. I have adjusted to add weight for this and created a PR.

tiger5226 commented

2019-02-25 03:53:22 +01:00

(Migrated from github.com)

merged and deployed