Weight search results by effective_amount

kauffj commented

2017-10-11 15:36:42 +02:00

(Migrated from github.com)

Prompted by the fact that if I search "disaster", "It's A Disaster" is currently the third result.

tiger5226 commented

2018-03-17 18:24:22 +01:00

(Migrated from github.com)

This is a nice improvement. We currently don't have access to effective_amount in the elastic document. However, as part of ChainQuery we can ensure this information is sent from there so it can be included in the elastic document to be used as a weight on the search score.

This is a nice improvement. We currently don't have access to `effective_amount` in the elastic document. However, as part of ChainQuery we can ensure this information is sent from there so it can be included in the elastic document to be used as a weight on the search score.

👍 1

tiger5226 commented

2018-05-13 01:51:59 +02:00

(Migrated from github.com)

Once #71 is closed out we can modify the elastic search query to give weight to the effective amount since it will now be coming from chainquery.

Once #71 is closed out we can modify the elastic search query to give weight to the effective amount since it will now be coming from [chainquery](https://github.com/lbryio/chainquery).

tiger5226 commented

2018-06-21 04:36:54 +02:00

(Migrated from github.com)

solved with https://github.com/lbryio/lighthouse/pull/81#event-1692597622

filipnyquist commented

2018-06-28 11:33:08 +02:00

(Migrated from github.com)

Closed, see comment above

tiger5226 commented

2018-06-30 15:04:50 +02:00

(Migrated from github.com)

reopening because while this is fixed in the leading branch it has not been deployed yet.

tiger5226 commented

2018-07-22 18:31:45 +02:00

(Migrated from github.com)

A quick update on this one. It was merged in but had to be rolled back. The function which used the effective amount as a factor of the score threw exceptions for certain documents which did not contain a number in the effective amount field. This should not have been the case. I could not reproduce this locally either. So maybe we need to plan a rebuild of the elastic search db in production. see docs here https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-function-score-query.html

alyssaoc commented

2018-08-20 23:46:19 +02:00

(Migrated from github.com)

@tiger5226 Is this still an outstanding issue? Will Sean's recent changes to search impact this?

tiger5226 commented

2018-08-21 00:13:53 +02:00

(Migrated from github.com)

yeah, it is but we need to come up with an alternative solution or fix the production elastic search instance.

@kauffj how important is this? Do we want to rebuild the production db? It takes about an hour to do it. So search would be down for an hour.

@nikooo777 Could we do this on another machine and replace it as lighthouse.lbry.io once complete so search does not go down?

yeah, it is but we need to come up with an alternative solution or fix the production elastic search instance. @kauffj how important is this? Do we want to rebuild the production db? It takes about an hour to do it. So search would be down for an hour. @nikooo777 Could we do this on another machine and replace it as lighthouse.lbry.io once complete so search does not go down?

nikooo777 commented

2018-08-21 11:36:32 +02:00

(Migrated from github.com)

@nikooo777 Could we do this on another machine and replace it as lighthouse.lbry.io once complete so search does not go down?

absolutely

> @nikooo777 Could we do this on another machine and replace it as lighthouse.lbry.io once complete so search does not go down? absolutely

filipnyquist commented

2018-08-21 12:03:10 +02:00

(Migrated from github.com)

Get a server and I can set it up!

Den 21 aug. 2018 11:36 skrev "Niko" notifications@github.com:

@nikooo777 https://github.com/nikooo777 Could we do this on another
machine and replace it as lighthouse.lbry.io once complete so search does
not go down?

absolutely

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lighthouse/issues/32#issuecomment-414614244,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKO8QuQ-eg3KTg7VDkKvbOLbv7JI1KpIks5uS9SvgaJpZM4P1fNJ
.

Get a server and I can set it up! Den 21 aug. 2018 11:36 skrev "Niko" <notifications@github.com>: @nikooo777 <https://github.com/nikooo777> Could we do this on another machine and replace it as lighthouse.lbry.io once complete so search does not go down? absolutely — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://github.com/lbryio/lighthouse/issues/32#issuecomment-414614244>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKO8QuQ-eg3KTg7VDkKvbOLbv7JI1KpIks5uS9SvgaJpZM4P1fNJ> .

kauffj commented

2018-08-21 15:45:25 +02:00

(Migrated from github.com)

It looks like you guys already figured out the approach on how to do this that I would have recommended.

It's unclear how much value this will have, but I think it's a smart change. It did make me realize we should figure out ways to ascertain how search is performing and I will file a ticket related to that.

It looks like you guys already figured out the approach on how to do this that I would have recommended. It's unclear how much value this will have, but I think it's a smart change. It did make me realize we should figure out ways to ascertain how search is performing and I will file a ticket related to that.

filipnyquist commented

2018-08-24 19:20:12 +02:00

(Migrated from github.com)

This change has been deployed to the main lighthouse instance.

👍 1

Weight search results by effective_amount #32