lighthouse documentation is not working #47

Closed
opened 2018-02-13 22:45:06 +01:00 by lbrydocs · 3 comments
lbrydocs commented 2018-02-13 22:45:06 +01:00 (Migrated from github.com)

Try the autocomplete function here, it fails:

https://lbryio.github.io/lighthouse/

Try the autocomplete function here, it fails: https://lbryio.github.io/lighthouse/
tiger5226 commented 2018-03-17 18:20:19 +01:00 (Migrated from github.com)

I split out the original issue into 3 separate problems that need to be solved. This one and #55, #56
I updated the comments to align with that.

I split out the original issue into 3 separate problems that need to be solved. This one and #55, #56 I updated the comments to align with that.
tiger5226 commented 2018-04-08 08:20:25 +02:00 (Migrated from github.com)

Solved by PR #60

Updated API docs to fix documentation errors on github pages which is the target of the documentation. The main culprit was not having cors enabled to handle the same origin policy of the browsers and making sure the docs pointed to the actual apis instead of localhost. With the koa-cors package now enabled this will work perfectly.

https://www.w3.org/TR/cors/

https://www.html5rocks.com/en/tutorials/cors/

Cross Origin Resource Sharing if not enabled prevents calls to an api like ours if it is coming from outside the domain. This is specific to web browsers. We don't see it in our app being blocked because that is using electron. However, someone using chrome or firefox would be blocked by the Same Origin Policy all browsers enforce.

Solved by PR #60 Updated API docs to fix documentation errors on github pages which is the target of the documentation. The main culprit was not having cors enabled to handle the same origin policy of the browsers and making sure the docs pointed to the actual apis instead of localhost. With the koa-cors package now enabled this will work perfectly. https://www.w3.org/TR/cors/ https://www.html5rocks.com/en/tutorials/cors/ Cross Origin Resource Sharing if not enabled prevents calls to an api like ours if it is coming from outside the domain. This is specific to web browsers. We don't see it in our app being blocked because that is using electron. However, someone using chrome or firefox would be blocked by the Same Origin Policy all browsers enforce.
filipnyquist commented 2018-04-08 09:24:40 +02:00 (Migrated from github.com)

This is now solved by PR #60. Closing!

This is now solved by PR #60. Closing!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/lighthouse.js#47
No description provided.