lighthouse documentation is not working #47
Labels
No labels
area: app c
area: app d
area: devops
area: discovery
area: docs
area: proposal
area: X-device Sync
Chainquery
consider soon
dependencies
Epic
Fix till next release
good first issue
hacktoberfest
help wanted
icebox
Invalid
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Parked
priority: blocker
priority: high
priority: low
priority: medium
Tom's Wishlist
type: bug
type: discussion
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: LBRYCommunity/lighthouse.js#47
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Try the autocomplete function here, it fails:
https://lbryio.github.io/lighthouse/
I split out the original issue into 3 separate problems that need to be solved. This one and #55, #56
I updated the comments to align with that.
Solved by PR #60
Updated API docs to fix documentation errors on github pages which is the target of the documentation. The main culprit was not having cors enabled to handle the same origin policy of the browsers and making sure the docs pointed to the actual apis instead of localhost. With the koa-cors package now enabled this will work perfectly.
https://www.w3.org/TR/cors/
https://www.html5rocks.com/en/tutorials/cors/
Cross Origin Resource Sharing if not enabled prevents calls to an api like ours if it is coming from outside the domain. This is specific to web browsers. We don't see it in our app being blocked because that is using electron. However, someone using chrome or firefox would be blocked by the Same Origin Policy all browsers enforce.
This is now solved by PR #60. Closing!