spent claims show up in search results #76

New issue

Closed

opened 2018-05-20 17:46:28 +02:00 by tiger5226 · 2 comments

tiger5226 commented

2018-05-20 17:46:28 +02:00

(Migrated from github.com)

When lighthouse queries chainquery for updated/new claims it doesn't do a check if it is spent.

It needs to check if the claim is spent and then delete it from elastic search so it is no longer searchable. The app will not resolve a spent claim and will only show that the position is available if someone wants to use it. cd0f980904
Lighthouse also needs to delete claims from elastic search that are expired. cd0f980904

When lighthouse queries chainquery for updated/new claims it doesn't do a check if it is spent. - [x] It needs to check if the claim is spent and then delete it from elastic search so it is no longer searchable. The app will not resolve a spent claim and will only show that the position is available if someone wants to use it. cd0f9809042011630bb7875e1314c481954c6029 - [x] Lighthouse also needs to delete claims from elastic search that are expired. cd0f9809042011630bb7875e1314c481954c6029

tiger5226 commented

2018-05-27 04:31:24 +02:00

(Migrated from github.com)

The screenshot above is a test case. The local version does not return the result while production currently does.

"name":"jellyfishasda6s54d10as6","claimId":"f0dd8afe152f673e2d04aeabbeb9edf7204087e8"

There is also a dependency on chainquery. The claim must be spent in chainquery in order for this to be verifiable.

This can be checked here. The bid state must be "Spent" in order for lighthouse to be expected to remove it.

There is a dependency on Chainquery. Chainquery needs to be updated first to correctly handle spent claims.

PR #77

<img width="1431" alt="screen shot 2018-05-26 at 10 28 52 pm" src="https://user-images.githubusercontent.com/3402064/40581946-67bcf55c-6134-11e8-8581-2a8603700def.png"> The screenshot above is a test case. The local version does not return the result while production currently does. `"name":"jellyfishasda6s54d10as6","claimId":"f0dd8afe152f673e2d04aeabbeb9edf7204087e8"` There is also a dependency on chainquery. The claim must be spent in chainquery in order for this to be verifiable. This can be checked [here](https://chainquery.lbry.io/api/sql?query=SELECT%20name,%20claim_id,bid_state%20FROM%20claim%20WHERE%20claim_id%20=%20%22f0dd8afe152f673e2d04aeabbeb9edf7204087e8%22). The bid state must be "Spent" in order for lighthouse to be expected to remove it. There is a dependency on Chainquery. Chainquery needs to be updated first to correctly handle spent claims. PR #77

tiger5226 commented

2018-05-27 16:54:40 +02:00

(Migrated from github.com)

This has been deployed along side the chainquery release and the test case passes in production.