concurrency flags, fixes

cmd/upload.go

@@ -18,6 +18,8 @@ import (
 	"github.com/spf13/cobra"
 )
 
+var workers int
+
 func init() {
 	var cmd = &cobra.Command{
 		Use:   "upload DIR",
@@ -25,6 +27,7 @@ func init() {
 		Args:  cobra.ExactArgs(1),
 		Run:   uploadCmd,
 	}
+	cmd.PersistentFlags().IntVar(&workers, "workers", 1, "How many worker threads to run at once")
 	RootCmd.AddCommand(cmd)
 }
 
@@ -54,11 +57,9 @@ func uploadCmd(cmd *cobra.Command, args []string) {
 
 	var filenames []string
 	for _, file := range files {
-		if file.IsDir() {
+		if !file.IsDir() {
-			continue
+			filenames = append(filenames, file.Name())
 		}
-
-		filenames = append(filenames, file.Name())
 	}
 
 	totalCount := len(filenames)
@@ -74,34 +75,15 @@ func uploadCmd(cmd *cobra.Command, args []string) {
 	sdCount := 0
 	blobCount := 0
 
-	concurrency := 2
+	workerWG := &sync.WaitGroup{}
-	wg := &sync.WaitGroup{}
 	filenameChan := make(chan string)
-	sdChan := make(chan int)
+	counterWG := &sync.WaitGroup{}
-	blobChan := make(chan int)
+	countChan := make(chan bool)
 
-	go func() {
+	for i := 0; i < workers; i++ {
-		wg.Add(1)
-		defer wg.Done()
-		for {
-			select {
-			case <-stopper.Chan():
-				return
-			case <-sdChan:
-				sdCount++
-			case <-blobChan:
-				blobCount++
-			}
-			if (sdCount+blobCount)%50 == 0 {
-				log.Printf("%d of %d done (%s elapsed)", sdCount+blobCount, totalCount-existsCount, time.Now().Sub(startTime).String())
-			}
-		}
-	}()
-
-	for i := 0; i < concurrency; i++ {
 		go func(i int) {
-			wg.Add(1)
+			workerWG.Add(1)
-			defer wg.Done()
+			defer workerWG.Done()
 			defer func(i int) {
 				log.Printf("worker %d quitting", i)
 			}(i)
@@ -130,14 +112,14 @@ func uploadCmd(cmd *cobra.Command, args []string) {
 						log.Printf("worker %d: PUTTING SD BLOB %s", i, hash)
 						blobStore.PutSD(hash, blob)
 						select {
-						case sdChan <- 1:
+						case countChan <- true:
 						case <-stopper.Chan():
 						}
 					} else {
 						log.Printf("worker %d: putting %s", i, hash)
 						blobStore.Put(hash, blob)
 						select {
-						case blobChan <- 1:
+						case countChan <- false:
 						case <-stopper.Chan():
 						}
 					}
@@ -146,6 +128,28 @@ func uploadCmd(cmd *cobra.Command, args []string) {
 		}(i)
 	}
 
+	go func() {
+		counterWG.Add(1)
+		defer counterWG.Done()
+		for {
+			select {
+			case <-stopper.Chan():
+				return
+			case isSD, ok := <-countChan:
+				if !ok {
+					return
+				} else if isSD {
+					sdCount++
+				} else {
+					blobCount++
+				}
+			}
+			if (sdCount+blobCount)%50 == 0 {
+				log.Printf("%d of %d done (%s elapsed, %.2fs per blob)", sdCount+blobCount, totalCount-existsCount, time.Now().Sub(startTime).String(), time.Now().Sub(startTime).Seconds()/float64(sdCount+blobCount))
+			}
+		}
+	}()
+
 Upload:
 	for _, filename := range filenames {
 		if exists[filename] {
@@ -161,10 +165,11 @@ Upload:
 	}
 
 	close(filenameChan)
-	wg.Wait()
+	workerWG.Wait()
+	close(countChan)
+	counterWG.Wait()
 	stopper.Stop()
 
-	log.Println("")
 	log.Println("SUMMARY")
 	log.Printf("%d blobs total", totalCount)
 	log.Printf("%d SD blobs uploaded", sdCount)