Vacuum the rugs again #17

Closed
opened 2018-08-07 03:19:23 +02:00 by tiger5226 · 1 comment
tiger5226 commented 2018-08-07 03:19:23 +02:00 (Migrated from github.com)

Cleanup the code so that it passes travis testing.

Cleanup the code so that it passes travis testing.
lyoshenka commented 2018-08-09 01:46:22 +02:00 (Migrated from github.com)

I disabled some of the linting that was failing. Some of it is useful, some
of it makes you do “best practices” that don’t make sense for us (like
commenting every exported thing). I support automating that stuff, but
don’t want to go overboard.

On Mon, Aug 6, 2018 at 9:19 PM Mark notifications@github.com wrote:

Cleanup the code so that it passes travis testing.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/reflector.go/issues/17, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWJIHnBTFLFulOfdSEudeY0i5YJtazQks5uOOsbgaJpZM4VxVHj
.

I disabled some of the linting that was failing. Some of it is useful, some of it makes you do “best practices” that don’t make sense for us (like commenting every exported thing). I support automating that stuff, but don’t want to go overboard. On Mon, Aug 6, 2018 at 9:19 PM Mark <notifications@github.com> wrote: > Cleanup the code so that it passes travis testing. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/lbryio/reflector.go/issues/17>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAWJIHnBTFLFulOfdSEudeY0i5YJtazQks5uOOsbgaJpZM4VxVHj> > . >
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/reflector.go#17
No description provided.