upgrade to lbry.go v2.4.0 #30

Merged

anbsky merged 4 commits from lbry_tv into master

2019-12-16 16:53:01 +01:00

anbsky commented

2019-11-21 05:36:33 +01:00

(Migrated from github.com)

This includes updated references to the latest lbry.go version.

I also downgraded some excessive INFO-level logging calls to DEBUG.

This includes updated references to the latest `lbry.go` version. I also downgraded some excessive INFO-level logging calls to DEBUG.

lyoshenka (Migrated from github.com) requested changes 2019-12-16 16:42:12 +01:00

lyoshenka (Migrated from github.com) left a comment

one small change requested. lgtm besides that

peer/store.go

lyoshenka (Migrated from github.com) commented

2019-12-16 16:37:33 +01:00

doing this is not a good idea. just set the 0 as the Client timeout. that already signals the Client to use a default.

if you do this here, not only is this duplicating code, but now if the Client's default changes, you'll be stuck on 5 seconds here (unless this was your intention???)

doing this is not a good idea. just set the 0 as the Client timeout. that already signals the Client to use a default. if you do this here, not only is this duplicating code, but now if the Client's default changes, you'll be stuck on 5 seconds here (unless this was your intention???)

peer/store.go

lyoshenka (Migrated from github.com) commented

2019-12-16 16:39:07 +01:00

i dont love this design here, but maybe there's no better way to do optional arguments in Go?

no need to spend much time on improving this. just thinking out loud.

i dont love this design here, but maybe there's no better way to do optional arguments in Go? no need to spend much time on improving this. just thinking out loud.

reflector/uploader.go

lyoshenka (Migrated from github.com) commented

2019-12-16 16:40:14 +01:00

❤️

:heart:

anbsky (Migrated from github.com) reviewed 2019-12-16 16:47:59 +01:00

peer/store.go

anbsky (Migrated from github.com) commented

2019-12-16 16:47:58 +01:00

Seems to be the default method of accepting optional parameters for functions (especially for constructors), I see it all the time in 3rd party code too. I personally would've preferred pattern matching (a la Elixir) or optional arguments (Python) but I simply don't see a better way in Go.

No reviewers

lyoshenka

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/reflector.go#30

No description provided.