LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Merge pull request #699 from lbryio/fixFailedLogClamp

Browse source 
Fix failed referrer clamp in logMetrics
This commit is contained in:
Shawn K 2018-11-09 10:57:30 -05:00 • committed by GitHub
commit e6400542e2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
server/middleware/logMetricsMiddleware.js
View file

@ -10,8 +10,14 @@ function logMetricsMiddleware(req, res, next) {
let referrer = req.get('referrer'); let referrer = req.get('referrer');
if(referrer && referrer.length > 255) { if(referrer && referrer.length > 255) {
try {
// Attempt to "safely" clamp long URLs // Attempt to "safely" clamp long URLs
referrer = /(.*?)#.*/.exec(referrer)[1]; referrer = /(.*?)#.*/.exec(referrer)[1];
} catch(e) {
// Cheap forced string conversion & clamp
referrer = new String(referrer);
referrer = referrer.substr(0, 255);
}
if(referrer.length > 255) { if(referrer.length > 255) {
logger.warn('Request refferer exceeds 255 characters:', referrer); logger.warn('Request refferer exceeds 255 characters:', referrer);