LBRYCommunity/spee.ch

Fork 0

wrong image is returned to user #126

New issue

Closed

opened 2017-08-03 01:36:01 +02:00 by bones7242 · 7 comments

bones7242 commented

2017-08-03 01:36:01 +02:00

(Migrated from github.com)

Issue: A user will publish an image through spee.ch, but when they check the url, a different image is served to them.

MSFTserver commented

2017-09-07 20:48:43 +02:00

(Migrated from github.com)

ok so i can display the correct image if i void out the /media and use the href link with .png at the end
would this be an option or is the /media needed for something?

ok so i can display the correct image if i void out the /media and use the href link with .png at the end would this be an option or is the /media needed for something?

MSFTserver commented

2017-09-07 20:54:32 +02:00

(Migrated from github.com)

example:

go here https://spee.ch/423dac99270f7f17675d1114f5b80cc191e4e46a/non-closing.png
open developer tools -> copy href link -> paste link into img class (sometime href doesnt have .png so append that if needed)

Gif of process:

https://spee.ch/e/display-correct-image.gif

before:

After:

### example: go here https://spee.ch/423dac99270f7f17675d1114f5b80cc191e4e46a/non-closing.png open developer tools -> copy href link -> paste link into `img` class (sometime href doesnt have .png so append that if needed) ### Gif of process: https://spee.ch/e/display-correct-image.gif ### before: ![image](https://user-images.githubusercontent.com/18357967/30180226-02e20ed0-93c4-11e7-9019-2b3fec411223.png) ### After: ![image](https://user-images.githubusercontent.com/18357967/30180275-30519ca0-93c4-11e7-8612-815c7e2a44bb.png)

tzarebczan commented

2017-10-17 22:13:05 +02:00

(Migrated from github.com)

Here's another one I just uploaded: https://spee.ch/b48717470b62676fc4e1ecc1f1bad66427d0a137/genwyn1 which shows some bitcoin download image

It should be showing this foxy lady: https://spee.ch/@randomnsfw:ce99ee6b2ad23a0d8a3fc66d017ab599d8be1b4d

Maybe something to do with the filename? It was download.jpg

Here's another one I just uploaded: https://spee.ch/b48717470b62676fc4e1ecc1f1bad66427d0a137/genwyn1 which shows some bitcoin download image It should be showing this foxy lady: https://spee.ch/@randomnsfw:ce99ee6b2ad23a0d8a3fc66d017ab599d8be1b4d Maybe something to do with the filename? It was download.jpg

MSFTserver commented

2017-10-17 22:31:03 +02:00

(Migrated from github.com)

@tzarebczan yes that the filename issue it servers <img class="image-show" src="/media/download.jpg"> from media and it should be<img class="image-show" src="/b48717470b62676fc4e1ecc1f1bad66427d0a137/genwyn1.jpg">

we should serve the href link above in the a tag

@tzarebczan yes that the filename issue it servers `<img class="image-show" src="/media/download.jpg">` from media and it should be`<img class="image-show" src="/b48717470b62676fc4e1ecc1f1bad66427d0a137/genwyn1.jpg"> ` we should serve the href link above in the a tag

MSFTserver commented

2017-10-17 22:31:54 +02:00

(Migrated from github.com)

atleast thats the quick fix i found

MSFTserver commented

2017-10-17 22:33:34 +02:00

(Migrated from github.com)

not sure why even use the media folder for serving id think wed just need that for lbry end

user uploads file, goes to media then it uses that folder to publish to lbry, found that using /claimid/image.jpeg, will serve the image so is media even necessary on clients end?

not sure why even use the media folder for serving id think wed just need that for lbry end user uploads file, goes to media then it uses that folder to publish to lbry, found that using /claimid/image.jpeg, will serve the image so is media even necessary on clients end?

bones7242 commented

2017-10-17 23:19:39 +02:00

(Migrated from github.com)

closing. fixed in current working branch redesign-1. thanks guys.

❤️ 1

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#126

No description provided.

Rows
Columns