Use existing thumbs for channel content #162

2017-09-11T21:46:21+02:00

bones7242 commented

2017-09-11 21:46:21 +02:00

(Migrated from github.com)

Added thumbnails for app-published videos viewed via the spee.ch/@channelname channel url
Added thumnails for app-published videos to opengraph/twitter meta tags

I need to refactor how the Request table records to associate them with records in the Claims table in order to extend thumbnail support to the spee.ch/popular listing.

- Added thumbnails for app-published videos viewed via the `spee.ch/@channelname` channel url - Added thumnails for app-published videos to opengraph/twitter meta tags I need to refactor how the `Request` table records to associate them with records in the `Claims` table in order to extend thumbnail support to the spee.ch/popular listing.

kauffj (Migrated from github.com) approved these changes 2017-09-11 23:43:39 +02:00

kauffj (Migrated from github.com) left a comment

One ultimate of nitpicks, just general comments otherwise.

Ship this at your leisure.

One ultimate of nitpicks, just general comments otherwise. Ship this at your leisure.

controllers/serveController.js

kauffj (Migrated from github.com) commented

2017-09-11 23:36:59 +02:00

DRY violation ;)

public/assets/css/componentStyle.css

					
				@ -154,27 +154,50 @@ button.copy-button {

					height: 1em;

kauffj (Migrated from github.com) commented

2017-09-11 23:39:34 +02:00

We ought to consider adopting a CSS class naming standard. I'm a fan of BEM http://getbem.com

This is non-blocking, but should probably be done before a large HTML/CSS change (such as the re-design).

We ought to consider adopting a CSS class naming standard. I'm a fan of BEM http://getbem.com This is non-blocking, but should probably be done before a large HTML/CSS change (such as the re-design).

routes/page-routes.js

					
				@ -61,3 +60,3 @@

				    res.status(200).render('embed', { layout: 'embed', claimId, name, dummyParam });

				    res.status(200).render('embed', { layout: 'embed', claimId, name });

				  });

				  // route to display all free public claims at a given name

kauffj (Migrated from github.com) commented

2017-09-11 23:40:57 +02:00

🥂

:clinking_glasses:

bones7242 (Migrated from github.com) reviewed 2017-09-12 02:46:39 +02:00

public/assets/css/componentStyle.css

					
				@ -154,27 +154,50 @@ button.copy-button {

					height: 1em;

bones7242 (Migrated from github.com) commented

2017-09-12 02:46:39 +02:00

agreed

bones7242 (Migrated from github.com) reviewed 2017-09-12 03:00:09 +02:00

controllers/serveController.js

bones7242 (Migrated from github.com) commented

2017-09-12 03:00:09 +02:00

updated

bones7242 commented

2017-09-12 03:04:41 +02:00

(Migrated from github.com)

tested on production server. merging.

Sign in to join this conversation.

No reviewers

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#162