LBRYCommunity/spee.ch
1
0
Fork 0
Code Issues 95 Pull requests 2 Projects Releases 4 Packages Wiki Activity

Upload refactor #242

Merged
bones7242 merged 24 commits from upload-refactor into master 2017-11-13 21:39:21 +01:00
Conversation 0 Commits 24 Files changed 37 +707 -789
bones7242 commented 2017-11-06 18:02:08 +01:00 (Migrated from github.com)
Copy link
  • removed socket.io
  • updated client side upload process to use form data submission to spee.ch's publish api
  • consolidated client-side publish and validation functions into objects so they would be out of the global scope
  • updated the File record creation on the publish API to include the channel name in the File record if applicable
  • updated the error handling code on the back end to better return the specific error to the client
- removed socket.io - updated client side upload process to use form data submission to spee.ch's publish api - consolidated client-side publish and validation functions into objects so they would be out of the global scope - updated the File record creation on the publish API to include the channel name in the File record if applicable - updated the error handling code on the back end to better return the specific error to the client
kauffj (Migrated from github.com) requested changes 2017-11-10 18:37:40 +01:00
kauffj (Migrated from github.com) left a comment
Copy link

Feedback.

Feedback.
README.md
kauffj (Migrated from github.com) commented 2017-11-10 18:25:46 +01:00
Copy link

@lyoshenka I gather best practices re: API documentation have evolved. Should @billbitt consider swagger or something else to document these calls?

(May be out of scope for this PR and should instead be opened separately)

@lyoshenka I gather best practices re: API documentation have evolved. Should @billbitt consider swagger or something else to document these calls? (May be out of scope for this PR and should instead be opened separately)
auth/authentication.js
kauffj (Migrated from github.com) commented 2017-11-10 18:26:47 +01:00
Copy link

Why call this then if skipAuth is true?

Why call this then if `skipAuth` is true?
config/speechConfig_example.js
kauffj (Migrated from github.com) commented 2017-11-10 18:24:47 +01:00
Copy link

A more common convention for this is probably speechConfig.example.js or speechConfig.js.example.

A more common convention for this is probably `speechConfig.example.js` or `speechConfig.js.example`.
controllers/publishController.js
@ -25,2 +30,2 @@
logger.debug('channel for publish not found in Channel table');
};
channelName = channel.channelName;
}
kauffj (Migrated from github.com) commented 2017-11-10 18:28:28 +01:00
Copy link

Missing let?

Missing `let`?
helpers/errorHandlers.js
kauffj (Migrated from github.com) commented 2017-11-10 18:30:43 +01:00
Copy link

[error, message] = this.returnErrorMessageAndStatus(error)

Prob worth spending some time reading/learning on ES2016 destructuring as well as spread operators.

[error, message] = this.returnErrorMessageAndStatus(error) Prob worth spending some time reading/learning on ES2016 destructuring as well as spread operators.
kauffj (Migrated from github.com) commented 2017-11-10 18:30:58 +01:00
Copy link

same as above

same as above
public/assets/js/publishFileFunctions.js
kauffj (Migrated from github.com) commented 2017-11-10 18:33:00 +01:00
Copy link

Presumably const

Presumably `const`
kauffj (Migrated from github.com) commented 2017-11-10 18:33:35 +01:00
Copy link

Late on catching this one, but this function name doesn't imply it is redirecting me to the homepage.

Late on catching this one, but this function name doesn't imply it is redirecting me to the homepage.
bones7242 (Migrated from github.com) reviewed 2017-11-13 18:13:06 +01:00
auth/authentication.js
bones7242 (Migrated from github.com) commented 2017-11-13 18:13:06 +01:00
Copy link

good point. I was struggling with how to best do this in the promise chain, but I now abstracted this to its own function

good point. I was struggling with how to best do this in the promise chain, but I now abstracted this to its own function
bones7242 (Migrated from github.com) reviewed 2017-11-13 20:25:03 +01:00
config/speechConfig_example.js
bones7242 (Migrated from github.com) commented 2017-11-13 20:25:03 +01:00
Copy link

I like speechConfig.js.example

I like `speechConfig.js.example`
bones7242 (Migrated from github.com) reviewed 2017-11-13 20:26:24 +01:00
controllers/publishController.js
@ -25,2 +30,2 @@
logger.debug('channel for publish not found in Channel table');
};
channelName = channel.channelName;
}
bones7242 (Migrated from github.com) commented 2017-11-13 20:26:24 +01:00
Copy link

defined on line 9 to hoist and make available further down promise chain

defined on line 9 to hoist and make available further down promise chain
bones7242 (Migrated from github.com) reviewed 2017-11-13 21:38:49 +01:00
README.md
bones7242 (Migrated from github.com) commented 2017-11-13 21:38:49 +01:00
Copy link

I'll discuss with @lyoshenka and open separate PR for needed changes

I'll discuss with @lyoshenka and open separate PR for needed changes
Sign in to join this conversation.
Reviewers
No reviewers
kauffj
Labels
Clear labels   
area: devops

   
area: discovery

   
area: docs

   
area: livestream

   
area: proposal

Work is part of a proposal

  
consider soon

Discuss this issue at the next planning meeting, then remove this label

  
dependencies

Pull requests that update a dependency file

  
Epic

   
good first issue

   
hacktoberfest

Welcome to Hacktoberfest

  
help wanted

   
icebox

Long-term storage

  
level: 1

No knowledge of the existing code required

  
level: 2

Some knowledge of the existing code is recommended

  
level: 3

Significant knowledge of the existing code is recommended

  
level: 4

Intimate knowledge of the existing code is recommended

  
needs: exploration

Solution unclear, needs research

  
needs: grooming

Issue needs to be groomed before work can start

  
needs: priority

Priority level needs to be defined

  
needs: repro

Issue needs step-by-step instructions on how to reproduce in latest code

  
needs: tech design

Needs technical design signoff before implementation can begin

  
on hold

Temporarily paused

  
Osprey

Spee.ch special project

  
priority: blocker

Issue is blocking release, do ASAP

  
priority: high

Work needs to be moved into sprint ASAP

  
priority: low

Work should be done but can stay in the backlog for now

  
priority: medium

Work needs to be done within 2-3 sprints

  
protocol dependent

   
resilience

   
Tom's Wishlist

   
type: bug

Existing functionality is wrong or broken

  
type: discussion

A conversation. No specific changes requested

  
type: error handling

   
type: improvement

Existing (or partially existing) functionality needs to be changed

  
type: new feature

New functionality that does not exist yet

  
type: refactor

Minimal user-visible changes, but significant internal work

  
type: task

Either work that's not related to the code, or a small chore that does not fit into other categories

  
type: testing

Solution needs additional user testing

  
unplanned

Work that was not planned into the spirnt, took priority over planned work

No labels
area: devops
area: discovery
area: docs
area: livestream
area: proposal
consider soon
dependencies
Epic
good first issue
hacktoberfest
help wanted
icebox
level: 1
level: 2
level: 3
level: 4
needs: exploration
needs: grooming
needs: priority
needs: repro
needs: tech design
on hold
Osprey
priority: blocker
priority: high
priority: low
priority: medium
protocol dependent
resilience
Tom's Wishlist
type: bug
type: discussion
type: error handling
type: improvement
type: new feature
type: refactor
type: task
type: testing
unplanned
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#242
No description provided.
Delete branch "upload-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?