LBRYCommunity/spee.ch

Fork 0

general.css Video Skin Class Stlye Improvement #250

Merged

QuirkyRobots merged 4 commits from patch-5 into master

2017-11-14 23:27:56 +01:00

QuirkyRobots commented

2017-11-08 14:15:54 +01:00

(Migrated from github.com)

Previously, the global video element was styled to make it look better on the stand alone page. However; the class .showasset-light is the video skin class assigned to the stand alone page only.

Based on this, I have optimised the style on this class and removed parts no longer needed from the video-player class, thereby not affecting any other pages for areas only required on the stand alone page.

Previously, the global video element was styled to make it look better on the stand alone page. However; the class `.showasset-light` is the video skin class assigned to the stand alone page only. Based on this, I have optimised the style on this class and removed parts no longer needed from the `video-player` class, thereby not affecting any other pages for areas only required on the stand alone page.

bones7242 (Migrated from github.com) reviewed 2017-11-09 20:32:13 +01:00

public/assets/css/general.css

bones7242 (Migrated from github.com) commented

2017-11-09 20:32:13 +01:00

I'm not sure about the box shadow in general, but I do think it works better on #video-player than on regular showlite-asset assets (e.g. pictures). How about moving it to #video-player.

I'm not sure about the box shadow in general, but I do think it works better on `#video-player` than on regular `showlite-asset` assets (e.g. pictures). How about moving it to #video-player.

bones7242 (Migrated from github.com) reviewed 2017-11-09 20:36:05 +01:00

public/assets/css/general.css

bones7242 (Migrated from github.com) commented

2017-11-09 20:36:05 +01:00

I think I prefer the images without a border., but also the margin: 0 auto; doesn't seem to be taking affect. I'd like to see what it looks like if the images are centered like the video. See picture in comment below.

I think I prefer the images without a border., but also the `margin: 0 auto;` doesn't seem to be taking affect. I'd like to see what it looks like if the images are centered like the video. See picture in comment below.

bones7242 (Migrated from github.com) requested changes 2017-11-09 20:39:55 +01:00

bones7242 (Migrated from github.com) left a comment

See comments. tl;dr I think this is going to be good, but I think the drop shadow should be on video player only, if we use it, and would suggest centered w/ no border for assets that are not in a video player. Open to discussion on that though.

QuirkyRobots commented

2017-11-10 05:59:08 +01:00

(Migrated from github.com)

Yes. The above CSS was for video only. Does .showasset-light affect images too?

All images need are positions, such as center, center and maybe scaling to fit in the page?

I really need to set this app up so I can test locally. Will do this today!

Yes. The above CSS was for video only. Does .showasset-light affect images too? All images need are positions, such as `center`, `center `and maybe scaling to fit in the page? I really need to set this app up so I can test locally. Will do this today!

QuirkyRobots commented

2017-11-10 18:09:31 +01:00

(Migrated from github.com)

ID's need to be applied. What are the ID's for the following 2 pages?

https://spee.ch/b39388bb9ffa8946dde2acd49fbdc01561eb2edd/Speechless3
https://spee.ch/b/Speechless3.mp4

ID's need to be applied. What are the ID's for the following 2 pages? https://spee.ch/b39388bb9ffa8946dde2acd49fbdc01561eb2edd/Speechless3 https://spee.ch/b/Speechless3.mp4

bones7242 commented

2017-11-10 18:24:08 +01:00

(Migrated from github.com)

https://spee.ch/b39388bb9ffa8946dde2acd49fbdc01561eb2edd/Speechless3 - <body id="show-body">
https://spee.ch/b/Speechless3.mp4 - <body id="showlite-body">

https://spee.ch/b39388bb9ffa8946dde2acd49fbdc01561eb2edd/Speechless3 - `<body id="show-body">` https://spee.ch/b/Speechless3.mp4 - `<body id="showlite-body">`

No reviewers

bones7242

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#250

No description provided.