added id tags to body elements #259

Merged
bones7242 merged 1 commit from body-id-tags into master 2017-11-10 16:17:34 +01:00
bones7242 commented 2017-11-09 20:51:20 +01:00 (Migrated from github.com)

@Smurphonomics what do you think? I added an id to the body for each layout.

the layouts are as follows:

  • main: general layout for homepage, about, login, 404, etc.
  • channel: channel overview page
  • show: layout for an asset displayed with details such as links and metadata
  • showlite: layout for an asset served directly with no extra info/metadata

Is this going to be specific enough, or should we put an id on each view rather than at the layout level

@Smurphonomics what do you think? I added an id to the body for each layout. the layouts are as follows: - main: general layout for homepage, about, login, 404, etc. - channel: channel overview page - show: layout for an asset displayed with details such as links and metadata - showlite: layout for an asset served directly with no extra info/metadata Is this going to be specific enough, or should we put an id on each view rather than at the layout level
QuirkyRobots commented 2017-11-10 05:52:48 +01:00 (Migrated from github.com)

Just as long as it's on each pages body tag, it'll be fine :)

Just as long as it's on each pages body tag, it'll be fine :)
QuirkyRobots commented 2017-11-10 06:49:46 +01:00 (Migrated from github.com)

By that I mean all pages such as stand alone pages. Example, the page that contains the raw media such as...

https://spee.ch/930a27d8fb833148fac9ea0f183a3ab8ec02be80/LBRY-Space-Ball.jpg

By that I mean all pages such as stand alone pages. Example, the page that contains the raw media such as... https://spee.ch/930a27d8fb833148fac9ea0f183a3ab8ec02be80/LBRY-Space-Ball.jpg
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#259
No description provided.