304 truncate description #314

2017-12-21T21:06:35+01:00

bones7242 commented

2017-12-21 21:06:35 +01:00

(Migrated from github.com)

moved open graph defaults from model layer to view layer
added a check that truncates descriptions to 200 characters at most

- moved open graph defaults from model layer to view layer - added a check that truncates descriptions to 200 characters at most

kauffj (Migrated from github.com) approved these changes 2017-12-29 16:09:18 +01:00

kauffj (Migrated from github.com) left a comment

LGTM

helpers/handlebarsHelpers.js

					
				@ -3,0 +47,4 @@

				}

				function createOpenGraphDataFromClaim (claim, defaultTitle, defaultDescription) {

				  let openGraphData = {};

kauffj (Migrated from github.com) commented

2017-12-29 16:09:01 +01:00

"Create" is possibly not the correct word here? It's also possible to just do:

return {
  foo: "val",
  bar: "val2",
}

"Create" is possibly not the correct word here? It's also possible to just do: ``` return { foo: "val", bar: "val2", } ```

kauffj (Migrated from github.com) approved these changes 2018-01-02 23:04:25 +01:00

Sign in to join this conversation.

No reviewers

kauffj

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: LBRYCommunity/spee.ch#314

Rows
Columns